Issue 2434893003: Hide the page info dialog if the underlying webcontents is hidden.

Issue 2434893003: Hide the page info dialog if the underlying webcontents is hidden. (Closed)

Created:
4 years, 2 months ago by Ted C

Modified:
4 years, 2 months ago

Reviewers:
tsergeant

CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Hide the page info dialog if the underlying webcontents is hidden. BUG=621464 Committed: https://crrev.com/cd6c51e70c4e4a3098fe05cb0e64cf19ed08d5bb Cr-Commit-Position: refs/heads/master@{#426501}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -0 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	content/browser/android/web_contents_observer_proxy.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/android/web_contents_observer_proxy.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434893003/1

4 years, 2 months ago (2016-10-20 15:56:05 UTC) #5

commit-bot: I haz the power

4 years, 2 months ago (2016-10-21 13:19:05 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cd6c51e70c4e4a3098fe05cb0e64cf19ed08d5bb
Cr-Commit-Position: refs/heads/master@{#426501}