Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2434853003: DevTools: [Sources] sourcesNavigator should not rely on existance of main target (Closed)

Created:
4 years, 2 months ago by lushnikov
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Sources] sourcesNavigator should not rely on existance of main target BUG=657552 R=dgozman Committed: https://crrev.com/c81a7da4e2cbef80f12d8fdd3a2a6d1bb535c219 Cr-Commit-Position: refs/heads/master@{#426324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js View 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look
4 years, 2 months ago (2016-10-19 18:48:05 UTC) #1
dgozman
lgtm Should we merge?
4 years, 2 months ago (2016-10-19 19:50:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434853003/1
4 years, 2 months ago (2016-10-19 22:04:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 23:13:42 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:12:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c81a7da4e2cbef80f12d8fdd3a2a6d1bb535c219
Cr-Commit-Position: refs/heads/master@{#426324}

Powered by Google App Engine
This is Rietveld 408576698