Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2434813004: Prerender: remove possible race in browser tests to improve flakiness. (Closed)

Created:
4 years, 2 months ago by mattcary
Modified:
4 years, 2 months ago
Reviewers:
droger, pasko
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prerender: remove possible race in browser tests to improve flakiness. There may be a race condition that causes flakiness in the form of timeouts in several prerender browser tests involving waiting for prerender contents to be created. As I have not been able to reproduce the flakiness locally, I'm not sure this is actually a fix for the flakes. Fingers are crossed and wood is being knocked. BUG=657025 Committed: https://crrev.com/9b665496e6c89667a23ae09138fd982132664b40 Cr-Commit-Position: refs/heads/master@{#426446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M chrome/browser/prerender/prerender_test_utils.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.cc View 3 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
mattcary
4 years, 2 months ago (2016-10-20 09:50:22 UTC) #2
pasko
LGTM since it is a slight complication, can you add a TODO to revert it ...
4 years, 2 months ago (2016-10-20 10:11:10 UTC) #3
mattcary
On 2016/10/20 10:11:10, pasko wrote: > LGTM > > since it is a slight complication, ...
4 years, 2 months ago (2016-10-20 10:18:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434813004/1
4 years, 2 months ago (2016-10-20 10:18:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 10:57:46 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:17:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b665496e6c89667a23ae09138fd982132664b40
Cr-Commit-Position: refs/heads/master@{#426446}

Powered by Google App Engine
This is Rietveld 408576698