Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chromeos/network/network_sms_handler.cc

Issue 24348002: Migrate DBus service constants from flimflam namespace to shill namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased to ToT Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_profile_handler.cc ('k') | chromeos/network/network_sms_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_sms_handler.cc
diff --git a/chromeos/network/network_sms_handler.cc b/chromeos/network/network_sms_handler.cc
index 986317d9da8569be59d7c73eff22bb42d045b00f..ecbafe95d48d5b4adb3002609326da7059ee3ae6 100644
--- a/chromeos/network/network_sms_handler.cc
+++ b/chromeos/network/network_sms_handler.cc
@@ -378,7 +378,7 @@ void NetworkSmsHandler::RemoveObserver(Observer* observer) {
void NetworkSmsHandler::OnPropertyChanged(const std::string& name,
const base::Value& value) {
- if (name != flimflam::kDevicesProperty)
+ if (name != shill::kDevicesProperty)
return;
const base::ListValue* devices = NULL;
if (!value.GetAsList(&devices) || !devices)
@@ -414,10 +414,10 @@ void NetworkSmsHandler::ManagerPropertiesCallback(
return;
}
const base::Value* value;
- if (!properties.GetWithoutPathExpansion(flimflam::kDevicesProperty, &value) ||
+ if (!properties.GetWithoutPathExpansion(shill::kDevicesProperty, &value) ||
value->GetType() != base::Value::TYPE_LIST) {
LOG(ERROR) << "NetworkSmsHandler: No list value for: "
- << flimflam::kDevicesProperty;
+ << shill::kDevicesProperty;
return;
}
const base::ListValue* devices = static_cast<const base::ListValue*>(value);
@@ -453,23 +453,23 @@ void NetworkSmsHandler::DevicePropertiesCallback(
std::string device_type;
if (!properties.GetStringWithoutPathExpansion(
- flimflam::kTypeProperty, &device_type)) {
+ shill::kTypeProperty, &device_type)) {
LOG(ERROR) << "NetworkSmsHandler: No type for: " << device_path;
return;
}
- if (device_type != flimflam::kTypeCellular)
+ if (device_type != shill::kTypeCellular)
return;
std::string dbus_connection;
if (!properties.GetStringWithoutPathExpansion(
- flimflam::kDBusConnectionProperty, &dbus_connection)) {
+ shill::kDBusConnectionProperty, &dbus_connection)) {
LOG(ERROR) << "Device has no DBusConnection Property: " << device_path;
return;
}
std::string object_path_string;
if (!properties.GetStringWithoutPathExpansion(
- flimflam::kDBusObjectProperty, &object_path_string)) {
+ shill::kDBusObjectProperty, &object_path_string)) {
LOG(ERROR) << "Device has no DBusObject Property: " << device_path;
return;
}
« no previous file with comments | « chromeos/network/network_profile_handler.cc ('k') | chromeos/network/network_sms_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698