Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chromeos/network/network_configuration_handler.cc

Issue 24348002: Migrate DBus service constants from flimflam namespace to shill namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased to ToT Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_configuration_handler.cc
diff --git a/chromeos/network/network_configuration_handler.cc b/chromeos/network/network_configuration_handler.cc
index 7748623e40558b221999677679995ef33c492cc1..f464dee6387e2cb8a0af699f71f3e5edac8722c6 100644
--- a/chromeos/network/network_configuration_handler.cc
+++ b/chromeos/network/network_configuration_handler.cc
@@ -60,8 +60,7 @@ void GetPropertiesCallback(
std::string name =
shill_property_util::GetNameFromProperties(service_path, properties);
if (!name.empty()) {
- properties_copy->SetStringWithoutPathExpansion(
- flimflam::kNameProperty, name);
+ properties_copy->SetStringWithoutPathExpansion(shill::kNameProperty, name);
}
if (call_status != DBUS_METHOD_CALL_SUCCESS) {
// Because network services are added and removed frequently, we will see
@@ -92,15 +91,15 @@ void SetNetworkProfileErrorCallback(
}
bool IsPassphrase(const std::string& key) {
- return key == flimflam::kEapPrivateKeyPasswordProperty ||
- key == flimflam::kEapPasswordProperty ||
- key == flimflam::kL2tpIpsecPasswordProperty ||
- key == flimflam::kOpenVPNPasswordProperty ||
- key == flimflam::kPassphraseProperty ||
- key == flimflam::kOpenVPNOTPProperty ||
- key == flimflam::kEapPrivateKeyProperty ||
- key == flimflam::kEapPinProperty ||
- key == flimflam::kApnPasswordProperty;
+ return key == shill::kEapPrivateKeyPasswordProperty ||
+ key == shill::kEapPasswordProperty ||
+ key == shill::kL2tpIpsecPasswordProperty ||
+ key == shill::kOpenVPNPasswordProperty ||
+ key == shill::kPassphraseProperty ||
+ key == shill::kOpenVPNOTPProperty ||
+ key == shill::kEapPrivateKeyProperty ||
+ key == shill::kEapPinProperty ||
+ key == shill::kApnPasswordProperty;
}
void LogConfigProperties(const std::string& desc,
@@ -285,13 +284,13 @@ void NetworkConfigurationHandler::CreateConfiguration(
ShillManagerClient* manager =
DBusThreadManager::Get()->GetShillManagerClient();
std::string type;
- properties.GetStringWithoutPathExpansion(flimflam::kTypeProperty, &type);
+ properties.GetStringWithoutPathExpansion(shill::kTypeProperty, &type);
NET_LOG_USER("CreateConfiguration", type);
LogConfigProperties("Configure", type, properties);
std::string profile;
- properties.GetStringWithoutPathExpansion(flimflam::kProfileProperty,
+ properties.GetStringWithoutPathExpansion(shill::kProfileProperty,
&profile);
DCHECK(!profile.empty());
manager->ConfigureServiceForProfile(
@@ -333,7 +332,7 @@ void NetworkConfigurationHandler::SetNetworkProfile(
base::StringValue profile_path_value(profile_path);
DBusThreadManager::Get()->GetShillServiceClient()->SetProperty(
dbus::ObjectPath(service_path),
- flimflam::kProfileProperty,
+ shill::kProfileProperty,
profile_path_value,
callback,
base::Bind(&SetNetworkProfileErrorCallback,

Powered by Google App Engine
This is Rietveld 408576698