third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl - Issue 2434763002: [wrapper-tracing] Bring remoteplayback up to date

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

Issue 2434763002: [wrapper-tracing] Bring remoteplayback up to date (Closed)

Patch Set: Reset bingings results Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

index 52a6e0aa55e0bd3cc8418f1b068960df10605789..03e66568685f5141f462152918cd58d6d4650822 100644

--- a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

@@ -16,7 +16,8 @@ class ScriptState;

class {{forward_declaration}};

{% endfor %}

-class {{exported}}{{cpp_class}} final : public GarbageCollectedFinalized<{{cpp_class}}> {

+class {{exported}}{{cpp_class}} final : public GarbageCollectedFinalized<{{cpp_class}}>,

+ public TraceWrapperBase {

public:

static {{cpp_class}}* create(v8::Isolate* isolate, v8::Local<v8::Function> callback)

@@ -27,6 +28,7 @@ public:

~{{cpp_class}}() = default;

DECLARE_TRACE();

+ DECLARE_TRACE_WRAPPERS();

bool call({{argument_declarations | join(', ')}});