Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1639)

Unified Diff: test/cctest/test-macro-assembler-arm.cc

Issue 2434753003: [cleanup] Delete MacroAssembler::CopyBytes, it is dead code (Closed)
Patch Set: update .golden files Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-macro-assembler-arm.cc
diff --git a/test/cctest/test-macro-assembler-arm.cc b/test/cctest/test-macro-assembler-arm.cc
index 24ab60e972e1b7718c4d12abd23504f3bc38ed6a..06efc58cfa26a2cd3fde8a6df56ba525c113100a 100644
--- a/test/cctest/test-macro-assembler-arm.cc
+++ b/test/cctest/test-macro-assembler-arm.cc
@@ -42,98 +42,6 @@ typedef void* (*F)(int x, int y, int p2, int p3, int p4);
#define __ masm->
-
-static byte to_non_zero(int n) {
- return static_cast<unsigned>(n) % 255 + 1;
-}
-
-
-static bool all_zeroes(const byte* beg, const byte* end) {
- CHECK(beg);
- CHECK(beg <= end);
- while (beg < end) {
- if (*beg++ != 0)
- return false;
- }
- return true;
-}
-
-
-TEST(CopyBytes) {
- CcTest::InitializeVM();
- Isolate* isolate = CcTest::i_isolate();
- HandleScope handles(isolate);
-
- const int data_size = 1 * KB;
- size_t act_size;
-
- // Allocate two blocks to copy data between.
- byte* src_buffer =
- static_cast<byte*>(v8::base::OS::Allocate(data_size, &act_size, 0));
- CHECK(src_buffer);
- CHECK(act_size >= static_cast<size_t>(data_size));
- byte* dest_buffer =
- static_cast<byte*>(v8::base::OS::Allocate(data_size, &act_size, 0));
- CHECK(dest_buffer);
- CHECK(act_size >= static_cast<size_t>(data_size));
-
- // Storage for R0 and R1.
- byte* r0_;
- byte* r1_;
-
- MacroAssembler assembler(isolate, NULL, 0,
- v8::internal::CodeObjectRequired::kYes);
- MacroAssembler* masm = &assembler;
-
- // Code to be generated: The stuff in CopyBytes followed by a store of R0 and
- // R1, respectively.
- __ CopyBytes(r0, r1, r2, r3);
- __ mov(r2, Operand(reinterpret_cast<int>(&r0_)));
- __ mov(r3, Operand(reinterpret_cast<int>(&r1_)));
- __ str(r0, MemOperand(r2));
- __ str(r1, MemOperand(r3));
- __ bx(lr);
-
- CodeDesc desc;
- masm->GetCode(&desc);
- Handle<Code> code = isolate->factory()->NewCode(
- desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
-
- F f = FUNCTION_CAST<F>(code->entry());
-
- // Initialise source data with non-zero bytes.
- for (int i = 0; i < data_size; i++) {
- src_buffer[i] = to_non_zero(i);
- }
-
- const int fuzz = 11;
-
- for (int size = 0; size < 600; size++) {
- for (const byte* src = src_buffer; src < src_buffer + fuzz; src++) {
- for (byte* dest = dest_buffer; dest < dest_buffer + fuzz; dest++) {
- memset(dest_buffer, 0, data_size);
- CHECK(dest + size < dest_buffer + data_size);
- (void)CALL_GENERATED_CODE(isolate, f, reinterpret_cast<int>(src),
- reinterpret_cast<int>(dest), size, 0, 0);
- // R0 and R1 should point at the first byte after the copied data.
- CHECK_EQ(src + size, r0_);
- CHECK_EQ(dest + size, r1_);
- // Check that we haven't written outside the target area.
- CHECK(all_zeroes(dest_buffer, dest));
- CHECK(all_zeroes(dest + size, dest_buffer + data_size));
- // Check the target area.
- CHECK_EQ(0, memcmp(src, dest, size));
- }
- }
- }
-
- // Check that the source data hasn't been clobbered.
- for (int i = 0; i < data_size; i++) {
- CHECK(src_buffer[i] == to_non_zero(i));
- }
-}
-
-
typedef int (*F5)(void*, void*, void*, void*, void*);
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/Modules.golden ('k') | test/cctest/test-macro-assembler-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698