Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5094)

Unified Diff: chrome/browser/chromeos/options/vpn_config_view.cc

Issue 2434683003: Move NetworkStateNotifier and NetworkConnect from src/ui (Closed)
Patch Set: Fix virtuals Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/net/shill_error.cc ('k') | chrome/browser/chromeos/options/wifi_config_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/options/vpn_config_view.cc
diff --git a/chrome/browser/chromeos/options/vpn_config_view.cc b/chrome/browser/chromeos/options/vpn_config_view.cc
index 3f14981cf350b6f81bb3ff8f45559046f777d747..7c09a4568e8f636365c9af9af5ad719bde76aae4 100644
--- a/chrome/browser/chromeos/options/vpn_config_view.cc
+++ b/chrome/browser/chromeos/options/vpn_config_view.cc
@@ -13,11 +13,13 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/chromeos/enrollment_dialog_view.h"
#include "chrome/browser/chromeos/net/onc_utils.h"
+#include "chrome/browser/chromeos/net/shill_error.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/common/net/x509_certificate_model.h"
#include "chrome/grit/generated_resources.h"
#include "chromeos/login/login_state.h"
#include "chromeos/network/network_configuration_handler.h"
+#include "chromeos/network/network_connect.h"
#include "chromeos/network/network_event_log.h"
#include "chromeos/network/network_state.h"
#include "chromeos/network/network_state_handler.h"
@@ -26,7 +28,6 @@
#include "third_party/cros_system_api/dbus/service_constants.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/models/combobox_model.h"
-#include "ui/chromeos/network/network_connect.h"
#include "ui/events/event.h"
#include "ui/views/controls/button/checkbox.h"
#include "ui/views/controls/combobox/combobox.h"
@@ -379,8 +380,7 @@ bool VPNConfigView::Login() {
false);
}
- ui::NetworkConnect::Get()->CreateConfigurationAndConnect(&properties,
- shared);
+ NetworkConnect::Get()->CreateConfigurationAndConnect(&properties, shared);
} else {
const NetworkState* vpn = NetworkHandler::Get()->network_state_handler()->
GetNetworkState(service_path_);
@@ -392,8 +392,8 @@ bool VPNConfigView::Login() {
}
base::DictionaryValue properties;
SetConfigProperties(&properties);
- ui::NetworkConnect::Get()->ConfigureNetworkAndConnect(
- service_path_, properties, false /* not shared */);
+ NetworkConnect::Get()->ConfigureNetworkAndConnect(service_path_, properties,
+ false /* not shared */);
}
return true; // Close dialog.
}
@@ -1004,8 +1004,8 @@ void VPNConfigView::UpdateErrorLabel() {
const NetworkState* vpn = NetworkHandler::Get()->network_state_handler()->
GetNetworkState(service_path_);
if (vpn && vpn->connection_state() == shill::kStateFailure)
- error_msg = ui::NetworkConnect::Get()->GetShillErrorString(
- vpn->last_error(), vpn->path());
+ error_msg =
+ shill_error::GetShillErrorString(vpn->last_error(), vpn->guid());
}
if (!error_msg.empty()) {
error_label_->SetText(error_msg);
« no previous file with comments | « chrome/browser/chromeos/net/shill_error.cc ('k') | chrome/browser/chromeos/options/wifi_config_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698