Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2434673002: media: Rename MojoMediaApplication to MediaService (Closed)

Created:
4 years, 2 months ago by xhwang
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, feature-media-reviews_chromium.org, Peter Beverloo, lcwu+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, posciak+watch_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, piman+watch_chromium.org, alokp+watch_chromium.org, darin (slow to review), jochen+watch_chromium.org, Aaron Boodman, alokp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Rename MojoMediaApplication to MediaService This follows the latest mojo naming convention since now MojoMediaApplication implements service_manager::Service and is registered for "service:media". TBR=jam@chromium.org BUG=657276 TEST=Renaming only. Committed: https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602 Cr-Commit-Position: refs/heads/master@{#426278}

Patch Set 1 #

Patch Set 2 : media: Rename MojoMediaApplication to MediaService #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -245 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M content/gpu/gpu_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/utility/utility_service_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/media_options.gni View 1 chunk +5 lines, -5 lines 0 comments Download
M media/mojo/services/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M media/mojo/services/default_mojo_media_client.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + media/mojo/services/media_service.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + media/mojo/services/media_service.cc View 2 chunks +11 lines, -14 lines 0 comments Download
A + media/mojo/services/media_service_factory.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + media/mojo/services/media_service_factory.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
D media/mojo/services/mojo_media_application.h View 1 chunk +0 lines, -68 lines 0 comments Download
D media/mojo/services/mojo_media_application.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D media/mojo/services/mojo_media_application_factory.h View 1 chunk +0 lines, -22 lines 0 comments Download
D media/mojo/services/mojo_media_application_factory.cc View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
xhwang
rockot: PTAL alokp: FYI
4 years, 2 months ago (2016-10-19 06:48:47 UTC) #3
alokp
chromecast/ lgtm Are you planning to rename MediaRendererService et al., to MediaFooImpl?
4 years, 2 months ago (2016-10-19 16:59:40 UTC) #9
xhwang
On 2016/10/19 16:59:40, alokp wrote: > chromecast/ lgtm > > Are you planning to rename ...
4 years, 2 months ago (2016-10-19 17:14:49 UTC) #10
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-19 19:06:29 UTC) #11
xhwang
4 years, 2 months ago (2016-10-19 19:40:48 UTC) #13
xhwang
TBRing jam@chromium.org on content/ changes since this is just a renaming CL.
4 years, 2 months ago (2016-10-19 19:41:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434673002/20001
4 years, 2 months ago (2016-10-19 19:42:21 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 20:56:16 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:11:18 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602
Cr-Commit-Position: refs/heads/master@{#426278}

Powered by Google App Engine
This is Rietveld 408576698