Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2434603004: Resume formatting card number after user deletes extra chars. (Closed)

Created:
4 years, 2 months ago by please use gerrit instead
Modified:
4 years, 2 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resume formatting card number after user deletes extra chars. If the user types in 17 digits in a credit card number field, Chrome stops formatting this number to look like a credit card number. When the user deletes the 17th digit, the remaining 16 digits should again be formatted to look like a credit card number. BUG=657606 Committed: https://crrev.com/de6ba8dcedb64c3000de0cf9dce866fc32726e15 Cr-Commit-Position: refs/heads/master@{#426629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/CreditCardNumberFormattingTextWatcher.java View 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
please use gerrit instead
twellington, ptal. Video of this patch in action is at https://drive.google.com/open?id=0BwnAxYoFTeYPaFMxbjUyNFJZNTg
4 years, 2 months ago (2016-10-19 20:50:52 UTC) #7
Theresa
lgtm
4 years, 2 months ago (2016-10-20 20:25:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434603004/20001
4 years, 2 months ago (2016-10-20 22:00:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-20 22:54:25 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:23:55 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de6ba8dcedb64c3000de0cf9dce866fc32726e15
Cr-Commit-Position: refs/heads/master@{#426629}

Powered by Google App Engine
This is Rietveld 408576698