ui/app_list/presenter/app_list_presenter_impl.cc - Issue 2434573004: Close app list widget when users click outside of the widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/app_list/presenter/app_list_presenter_impl.cc

Issue 2434573004: Close app list widget when users click outside of the widget (Closed)

Patch Set: Call AppListPresenterImpl::Dismiss() in AppListPresenterImpl::~AppListPresenterImpl() to ensure de… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/app_list/presenter/app_list_presenter_impl.cc

diff --git a/ui/app_list/presenter/app_list_presenter_impl.cc b/ui/app_list/presenter/app_list_presenter_impl.cc

index cd181d1657ed606e57ce605f0824b4b262a8eb1d..deab037fcb4953abee017954ddc0e44aeed56efb 100644

--- a/ui/app_list/presenter/app_list_presenter_impl.cc

+++ b/ui/app_list/presenter/app_list_presenter_impl.cc

@@ -37,6 +37,7 @@ AppListPresenterImpl::AppListPresenterImpl(

}

AppListPresenterImpl::~AppListPresenterImpl() {

+ AppListPresenterImpl::Dismiss();

mfomitchev 2016/10/20 19:52:23 remove "AppListPresenterImpl::"

thanhph 2016/10/20 19:58:07 Ok!

presenter_delegate_.reset();

// Ensures app list view goes before the controller since pagination model

// lives in the controller and app list view would access it on destruction.