Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2434563007: Fixed potential read-out-of-bounds issue in ICC profile loading (Closed)

Created:
4 years, 2 months ago by raftias
Modified:
4 years, 2 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fixed potential read-out-of-bounds issue in ICC profile loading For 8-bit precision color LUT in A2B0 ICC color space profiles it was skipping every 2nd CLUT value and then reading past the end of the CLUT data table. Now it properly increments through 8-bit precision color LUT tables in profiles. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2434563007 Committed: https://skia.googlesource.com/skia/+/80739b842ad0681333d40feda578d04044c8157f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkColorSpace_ICC.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
raftias
4 years, 2 months ago (2016-10-20 15:30:37 UTC) #4
msarett
lgtm
4 years, 2 months ago (2016-10-20 15:31:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434563007/1
4 years, 2 months ago (2016-10-20 17:17:43 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-20 17:39:06 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/80739b842ad0681333d40feda578d04044c8157f

Powered by Google App Engine
This is Rietveld 408576698