Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2434553004: DevTools: Select option background added to fix Dark theme (Closed)

Created:
4 years, 2 months ago by anth12
Modified:
4 years, 2 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Select option background added to fix Dark theme BUG=638202 Committed: https://crrev.com/8b2e1bd43027eaf52d8a525b4755831ffa88a8e6 Cr-Commit-Position: refs/heads/master@{#426751}

Patch Set 1 #

Patch Set 2 : Authors email changed to match registered account #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
anth12
Comments from https://codereview.chromium.org/2436563002 addressed, PTAL.
4 years, 2 months ago (2016-10-20 07:49:30 UTC) #2
lushnikov
good stuff, thanks! lgtm
4 years, 2 months ago (2016-10-20 21:17:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434553004/1
4 years, 2 months ago (2016-10-20 21:18:47 UTC) #7
commit-bot: I haz the power
The author anth.halliday12@gmail.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
4 years, 2 months ago (2016-10-20 21:18:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434553004/1
4 years, 2 months ago (2016-10-21 06:15:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/286711)
4 years, 2 months ago (2016-10-21 06:48:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434553004/20001
4 years, 2 months ago (2016-10-21 06:58:48 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 08:37:58 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:28:10 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b2e1bd43027eaf52d8a525b4755831ffa88a8e6
Cr-Commit-Position: refs/heads/master@{#426751}

Powered by Google App Engine
This is Rietveld 408576698