[Ash MD] Restore focus on detailed row when exiting detailed view

[Ash MD] Restore focus on detailed row when exiting detailed view

For Ash material design (--ash-md=experimental), restore
focus to the previously-focused system menu row
when transitioning away from a detailed view using
the keyboard (i.e., when the back button has focus and
the return key is pressed).

BUG=650776
TEST=TrayDetailsViewTest.TransitionToDefaultViewTest

Committed: https://crrev.com/999329346d570fcd2732b703691fc829021b7c54
Cr-Commit-Position: refs/heads/master@{#426524}

[tdanderson, 2016-10-19 21:30:58]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[tdanderson, 2016-10-19 21:31:20]

tdanderson@chromium.org changed reviewers:
+ varkha@chromium.org

[tdanderson, 2016-10-19 21:31:20]

Valery, can you please take a look?

[commit-bot: I haz the power, 2016-10-19 21:32:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:37:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:37:46]

Dry run: This issue passed the CQ dry run.

[varkha, 2016-10-20 15:34:38]

This change lgtm, thanks. I am tempted every time to try and return to the
previous view from a detailed view by pressing [arrow left] or [Esc] (this would
work if this were a regular menu). Do we not want that?

https://chromiumcodereview.appspot.com/2434553003/diff/1/ash/common/system/tr...
File ash/common/system/tray/tray_details_view.cc (right):

https://chromiumcodereview.appspot.com/2434553003/diff/1/ash/common/system/tr...
ash/common/system/tray/tray_details_view.cc:171: if
(MaterialDesignController::IsSystemTrayMenuMaterial()) {
Did you not merge this with the else if condition because when MDC will age out
of existence it would be easier to just remove the other condition? If so - I
agree that this is better even if it is not the shortest way to write this.

[varkha, 2016-10-20 15:34:39]

This change lgtm, thanks. I am tempted every time to try and return to the
previous view from a detailed view by pressing [arrow left] or [Esc] (this would
work if this were a regular menu). Do we not want that?

[tdanderson, 2016-10-20 16:54:37]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2016-10-20 16:54:38]

The patchset sent to the CQ was uploaded after l-g-t-m from varkha@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2434553003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-20 16:54:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2016-10-20 16:57:43]

On 2016/10/20 15:34:39, varkha wrote:
> This change lgtm, thanks. I am tempted every time to try and return to the
> previous view from a detailed view by pressing [arrow left] or [Esc] (this
would
> work if this were a regular menu). Do we not want that?

Interesting, that's something I had not thought about. Filed crbug.com/657889.

[commit-bot: I haz the power, 2016-10-20 17:53:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:19:55]

Description was changed from

==========
[Ash MD] Restore focus on detailed row when exiting detailed view

For Ash material design (--ash-md=experimental), restore
focus to the previously-focused system menu row
when transitioning away from a detailed view using
the keyboard (i.e., when the back button has focus and
the return key is pressed).

BUG=650776
TEST=TrayDetailsViewTest.TransitionToDefaultViewTest
==========

to

==========
[Ash MD] Restore focus on detailed row when exiting detailed view

For Ash material design (--ash-md=experimental), restore
focus to the previously-focused system menu row
when transitioning away from a detailed view using
the keyboard (i.e., when the back button has focus and
the return key is pressed).

BUG=650776
TEST=TrayDetailsViewTest.TransitionToDefaultViewTest

Committed: https://crrev.com/999329346d570fcd2732b703691fc829021b7c54
Cr-Commit-Position: refs/heads/master@{#426524}
==========

[commit-bot: I haz the power, 2016-10-21 13:19:59]

Patchset 2 (id:??) landed as
https://crrev.com/999329346d570fcd2732b703691fc829021b7c54
Cr-Commit-Position: refs/heads/master@{#426524}