Specified row height should be applied during initial section layout.

Specified row height should be applied during initial section layout.

BUG=534751
Committed: https://crrev.com/279c098b1ce1ce5b1021e744cf444237f3b0004f
Cr-Commit-Position: refs/heads/master@{#426441}

[mstensho (USE GERRIT), 2016-10-19 20:22:03]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 20:22:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mstensho (USE GERRIT), 2016-10-19 21:18:37]

mstensho@opera.com changed reviewers:
+ dgrogan@chromium.org, eae@chromium.org

[eae, 2016-10-19 21:57:42]

LGTM

https://codereview.chromium.org/2434543004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fragmentation/table-row-with-specified-height.html
(right):

https://codereview.chromium.org/2434543004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fragmentation/table-row-with-specified-height.html:9:
<tr id="secondRow" style="height:61px; background:blue;">
blue, like the high seas on a sunny day, I like it!

https://codereview.chromium.org/2434543004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTableSection.cpp (right):

https://codereview.chromium.org/2434543004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:1969: 
Could you please add an ASSERT that rowIndex < size before accessing it please?

[commit-bot: I haz the power, 2016-10-19 22:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:12:00]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2016-10-20 08:59:09]

https://codereview.chromium.org/2434543004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fragmentation/table-row-with-specified-height.html
(right):

https://codereview.chromium.org/2434543004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fragmentation/table-row-with-specified-height.html:9:
<tr id="secondRow" style="height:61px; background:blue;">
On 2016/10/19 21:57:42, eae wrote:
> blue, like the high seas on a sunny day, I like it!

If she stays calm throughout all the reflowing, this test maiden voyage case
passes!

https://codereview.chromium.org/2434543004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTableSection.cpp (right):

https://codereview.chromium.org/2434543004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:1969: 
On 2016/10/19 21:57:42, eae wrote:
> Could you please add an ASSERT that rowIndex < size before accessing it
please?

Aye aye, captain!

I have to learn to stop adding random blank lines to my CLs, to keep old
mistakes hidden. :)

[mstensho (USE GERRIT), 2016-10-20 08:59:14]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-10-20 08:59:14]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2434543004/#ps20001
(title: "Code review.")

[commit-bot: I haz the power, 2016-10-20 08:59:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 10:12:21]

Committed patchset #2 (id:20001)

[eae, 2016-10-20 16:52:00]

Set sail for adventure!

[commit-bot: I haz the power, 2016-10-21 13:16:58]

Description was changed from

==========
Specified row height should be applied during initial section layout.

BUG=534751
==========

to

==========
Specified row height should be applied during initial section layout.

BUG=534751

Committed: https://crrev.com/279c098b1ce1ce5b1021e744cf444237f3b0004f
Cr-Commit-Position: refs/heads/master@{#426441}
==========

[commit-bot: I haz the power, 2016-10-21 13:16:59]

Patchset 2 (id:??) landed as
https://crrev.com/279c098b1ce1ce5b1021e744cf444237f3b0004f
Cr-Commit-Position: refs/heads/master@{#426441}