Use SysNSStringToUTF8 instead of UTF8String in recent clipboard.

Use SysNSStringToUTF8 instead of UTF8String in recent clipboard.

It is possible that the string contained in the pasteboard is invalid.
In that case, [string UTF8String] can return nil when SysNSStringToUTF8 returns "".
URLFromPasteboard uses SysNSStringToUTF8.

Note:
[string canBeConvertedToEncoding:NSUTF8StringEncoding] is not reliable as it can return YES and UTF8String return nil.

BUG=656108
Committed: https://crrev.com/e687fefd7265a5e4cc580e73d6e0e028ed52c24c
Cr-Commit-Position: refs/heads/master@{#426463}

[Olivier, 2016-10-20 11:48:05]

olivierrobin@chromium.org changed reviewers:
+ jif@chromium.org

[Olivier, 2016-10-20 12:27:33]

Description was changed from

==========
Check pasteboard UTF8string before using it.

It is possible that the string contained in the pasteboard is invalid.
In that case, [string UTF8String] can return nil.
Check the conversion before using it.

Note:
[string canBeConvertedToEncoding:NSUTF8StringEncoding] is not reliable.

BUG=656108
==========

to

==========
Use SysNSStringToUTF8 instead of UTF8String in recent clipboard.

It is possible that the string contained in the pasteboard is invalid.
In that case, [string UTF8String] can return nil when SysNSStringToUTF8 returns
"".
URLFromPasteboard uses SysNSStringToUTF8.

Note:
[string canBeConvertedToEncoding:NSUTF8StringEncoding] is not reliable as it can
return YES and UTF8String return nil.

BUG=656108
==========

[Olivier, 2016-10-20 12:28:05]

I changed my mind.
Tell me if it is OK.

[jif-google, 2016-10-20 12:45:07]

On 2016/10/20 12:28:05, Olivier Robin wrote:
> I changed my mind.
> Tell me if it is OK.

lgtm

[Olivier, 2016-10-20 12:55:39]

The CQ bit was checked by olivierrobin@chromium.org

[commit-bot: I haz the power, 2016-10-20 12:55:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jif, 2016-10-20 13:06:23]

lgtm

[commit-bot: I haz the power, 2016-10-20 13:12:35]

Description was changed from

==========
Use SysNSStringToUTF8 instead of UTF8String in recent clipboard.

It is possible that the string contained in the pasteboard is invalid.
In that case, [string UTF8String] can return nil when SysNSStringToUTF8 returns
"".
URLFromPasteboard uses SysNSStringToUTF8.

Note:
[string canBeConvertedToEncoding:NSUTF8StringEncoding] is not reliable as it can
return YES and UTF8String return nil.

BUG=656108
==========

to

==========
Use SysNSStringToUTF8 instead of UTF8String in recent clipboard.

It is possible that the string contained in the pasteboard is invalid.
In that case, [string UTF8String] can return nil when SysNSStringToUTF8 returns
"".
URLFromPasteboard uses SysNSStringToUTF8.

Note:
[string canBeConvertedToEncoding:NSUTF8StringEncoding] is not reliable as it can
return YES and UTF8String return nil.

BUG=656108
==========

[commit-bot: I haz the power, 2016-10-20 13:12:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:17:51]

Description was changed from

==========
Use SysNSStringToUTF8 instead of UTF8String in recent clipboard.

It is possible that the string contained in the pasteboard is invalid.
In that case, [string UTF8String] can return nil when SysNSStringToUTF8 returns
"".
URLFromPasteboard uses SysNSStringToUTF8.

Note:
[string canBeConvertedToEncoding:NSUTF8StringEncoding] is not reliable as it can
return YES and UTF8String return nil.

BUG=656108
==========

to

==========
Use SysNSStringToUTF8 instead of UTF8String in recent clipboard.

It is possible that the string contained in the pasteboard is invalid.
In that case, [string UTF8String] can return nil when SysNSStringToUTF8 returns
"".
URLFromPasteboard uses SysNSStringToUTF8.

Note:
[string canBeConvertedToEncoding:NSUTF8StringEncoding] is not reliable as it can
return YES and UTF8String return nil.

BUG=656108

Committed: https://crrev.com/e687fefd7265a5e4cc580e73d6e0e028ed52c24c
Cr-Commit-Position: refs/heads/master@{#426463}
==========

[commit-bot: I haz the power, 2016-10-21 13:17:52]

Patchset 2 (id:??) landed as
https://crrev.com/e687fefd7265a5e4cc580e73d6e0e028ed52c24c
Cr-Commit-Position: refs/heads/master@{#426463}