Add coalesced KeyDown handling for arrow key scrolling.

Add coalesced KeyDown handling for arrow key scrolling.

Android switched to sending coalesced KeyDown instead of
RawKeyDown/Char pair in http://crrev.com/2206053002.  The arrow key
handler in Source/web in particular did not account for this case,
therefore arrow keys stopped scrolling on Android (although all other
uses of arrow keys handled in Source/core still work).

NOTRY=true
BUG=657158
Committed: https://crrev.com/5492e01d2bb022d2bdfab86250f5a4c543cea122
Cr-Commit-Position: refs/heads/master@{#426289}

[aelias_OOO_until_Jul13, 2016-10-19 17:55:08]

aelias@chromium.org changed reviewers:
+ skobes@chromium.org

[aelias_OOO_until_Jul13, 2016-10-19 17:55:09]

Hi skobes@, this is a candidate for very-last-minute 54 cherry-pick so I'd like
to land this cherry-pickable one-liner right now.  I'm working on a more
comprehensive and unit tested fix separately (early WIP at
https://codereview.chromium.org/2430183002).

https://codereview.chromium.org/2434463003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/2434463003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebViewImpl.cpp:1674: case WebInputEvent::Char:
Note that although Android does not send Char event either, surprisingly,
spacebar scrolling still works.  The reason is that spacebar scrolling is
handled by KeyboardEventManager::defaultSpaceEventHandler.  That gets dibs on
the event first, so as far as I can tell this spacebar switch clause has
actually been no-op for a long time.

[aelias_OOO_until_Jul13, 2016-10-19 17:55:44]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 17:56:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skobes, 2016-10-19 18:00:35]

lgtm

[commit-bot: I haz the power, 2016-10-19 20:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 20:03:13]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2016-10-19 21:01:32]

Description was changed from

==========
Add coalesced KeyDown handling for arrow key scrolling.

Android switched to sending coalesced KeyDown instead of
RawKeyDown/Char pair in http://crrev.com/2206053002.  The arrow key
handler in Source/web in particular did not account for this case,
therefore arrow keys stopped scrolling on Android (although all other
uses of arrow keys handled in Source/core still work).

BUG=657158
==========

to

==========
Add coalesced KeyDown handling for arrow key scrolling.

Android switched to sending coalesced KeyDown instead of
RawKeyDown/Char pair in http://crrev.com/2206053002.  The arrow key
handler in Source/web in particular did not account for this case,
therefore arrow keys stopped scrolling on Android (although all other
uses of arrow keys handled in Source/core still work).

NOTRY=true
BUG=657158
==========

[aelias_OOO_until_Jul13, 2016-10-19 21:01:34]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2016-10-19 21:02:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 21:28:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:11:36]

Description was changed from

==========
Add coalesced KeyDown handling for arrow key scrolling.

Android switched to sending coalesced KeyDown instead of
RawKeyDown/Char pair in http://crrev.com/2206053002.  The arrow key
handler in Source/web in particular did not account for this case,
therefore arrow keys stopped scrolling on Android (although all other
uses of arrow keys handled in Source/core still work).

NOTRY=true
BUG=657158
==========

to

==========
Add coalesced KeyDown handling for arrow key scrolling.

Android switched to sending coalesced KeyDown instead of
RawKeyDown/Char pair in http://crrev.com/2206053002.  The arrow key
handler in Source/web in particular did not account for this case,
therefore arrow keys stopped scrolling on Android (although all other
uses of arrow keys handled in Source/core still work).

NOTRY=true
BUG=657158

Committed: https://crrev.com/5492e01d2bb022d2bdfab86250f5a4c543cea122
Cr-Commit-Position: refs/heads/master@{#426289}
==========

[commit-bot: I haz the power, 2016-10-21 13:11:37]

Patchset 1 (id:??) landed as
https://crrev.com/5492e01d2bb022d2bdfab86250f5a4c543cea122
Cr-Commit-Position: refs/heads/master@{#426289}