Timeline: promisify paint profiler and Layers panel, part I

Timeline: promisify paint profiler and Layers panel, part I

Committed: https://crrev.com/94988100dfb70485b33d070c43ccd8ed7c346c4d
Cr-Commit-Position: refs/heads/master@{#426943}

[caseq, 2016-10-20 22:32:59]

caseq@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-10-21 00:25:11]

lgtm

https://codereview.chromium.org/2434393002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js
(right):

https://codereview.chromium.org/2434393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js:119:
return frame.layerTree.layerTreePromise().then(layerTree => layerTree ?
layerTree.pictureForRasterTile(tileId) : null);
nit: layerTree &&

https://codereview.chromium.org/2434393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js:405:
return;
null

https://codereview.chromium.org/2434393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js:418:
* @return {!Array<!WebInspector.LayerPaintEvent>} paints
drop paints

https://codereview.chromium.org/2434393002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js
(right):

https://codereview.chromium.org/2434393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js:31:
rect: !DOMAgent.Rect,
indent

https://codereview.chromium.org/2434393002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline_model/TracingLayerTree.js:417:
var topLeft = fragments.reduce((acc, current) => ({x: Math.min(acc.x,
current.x), y: Math.min(acc.y, current.y)}), {x: Infinity, y: Infinity});
For the sake of performance I'd do it with two reduces, for x and for y, so you
can avoid creating lots of temp objects.

[caseq, 2016-10-21 21:08:01]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-10-21 21:08:01]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2434393002/#ps40001
(title: "review comments addressed")

[commit-bot: I haz the power, 2016-10-21 21:08:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 21:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 21:45:46]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lushnikov, 2016-10-21 21:47:47]

lushnikov@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2016-10-21 21:47:47]

rs lgtm

[caseq, 2016-10-21 21:48:21]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-10-21 21:49:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 01:18:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-22 01:25:33]

Description was changed from

==========
Timeline: promisify paint profiler and Layers panel, part I
==========

to

==========
Timeline: promisify paint profiler and Layers panel, part I

Committed: https://crrev.com/94988100dfb70485b33d070c43ccd8ed7c346c4d
Cr-Commit-Position: refs/heads/master@{#426943}
==========

[commit-bot: I haz the power, 2016-10-22 01:25:34]

Patchset 3 (id:??) landed as
https://crrev.com/94988100dfb70485b33d070c43ccd8ed7c346c4d
Cr-Commit-Position: refs/heads/master@{#426943}