Handle duplicate media track ids in FFmpegDemuxer

Handle duplicate media track ids in FFmpegDemuxer

Previously we would just crash due to CHECK when we detected media
streams with duplicate bytestream ids. This CL adds explicit checks
for duplicate stream ids in FFmpegDemuxer and skips those streams.

BUG=657437
Committed: https://crrev.com/41ecabf2dc6286a0cc529cfe50eabe44c3a56c54
Cr-Commit-Position: refs/heads/master@{#426840}

[servolk, 2016-10-20 22:07:59]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 22:08:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2016-10-20 22:22:41]

Description was changed from

==========
Handle duplicated media track ids in FFmpegDemuxer

Previously we would just crash due to CHECK when we detected media
streams with duplicate bytestream ids. This CL adds explicit checks
for duplicate stream ids in FFmpegDemuxer and skips those streams.

BUG=657437
==========

to

==========
Handle duplicated media track ids in FFmpegDemuxer

Previously we would just crash due to CHECK when we detected media
streams with duplicate bytestream ids. This CL adds explicit checks
for duplicate stream ids in FFmpegDemuxer and skips those streams.

BUG=657437
==========

[servolk, 2016-10-20 22:22:41]

servolk@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[servolk, 2016-10-20 22:23:14]

Description was changed from

==========
Handle duplicated media track ids in FFmpegDemuxer

Previously we would just crash due to CHECK when we detected media
streams with duplicate bytestream ids. This CL adds explicit checks
for duplicate stream ids in FFmpegDemuxer and skips those streams.

BUG=657437
==========

to

==========
Handle duplicate media track ids in FFmpegDemuxer

Previously we would just crash due to CHECK when we detected media
streams with duplicate bytestream ids. This CL adds explicit checks
for duplicate stream ids in FFmpegDemuxer and skips those streams.

BUG=657437
==========

[DaleCurtis, 2016-10-20 22:24:58]

lgtm, a test would be nice if possible.

[commit-bot: I haz the power, 2016-10-20 22:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 22:52:29]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[servolk, 2016-10-20 23:01:31]

On 2016/10/20 22:24:58, DaleCurtis wrote:
> lgtm, a test would be nice if possible.

I'm not sure how to generate an .mp4 file with duplicate stream ids on purpose,
but I guess I can take the file generated by fuzzer, it is 43065 bytes.

[servolk, 2016-10-20 23:06:09]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 23:06:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2016-10-20 23:08:24]

lgtm

[commit-bot: I haz the power, 2016-10-21 00:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 00:03:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[servolk, 2016-10-21 01:19:07]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 01:20:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2016-10-21 03:08:24]

On 2016/10/20 23:08:24, DaleCurtis wrote:
> lgtm

Oops, sorry, I've looked at trybot failures and realized that previous patchsets
were problematic, because stream ids must be only unique per-stream-type, i.e.
it's fine to have audio stream with id X and video stream with id X. So I've
reworked a little and patchset #3 should be good.

[commit-bot: I haz the power, 2016-10-21 03:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-21 03:10:37]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2016-10-21 17:13:31]

Is it okay to overwrite an invalid entry? Or are there no entries that are not
valid besides the defaults?

[servolk, 2016-10-21 17:24:16]

On 2016/10/21 17:13:31, DaleCurtis wrote:
> Is it okay to overwrite an invalid entry? Or are there no entries that are not
> valid besides the defaults?

FFmpegDemuxerStream::Create fails if the config is invalid, therefore all tracks
added to the MediaTracks collection will have valid configs (there's actually
also a DCHECK that enforces valid configs in MediaTracks::AddAudio/VideoTrack).
Thus when getAudio/VideoTrack returns an invalid config, that means that track
with that id hasn't been added to the MediaTracks collection yet.

[DaleCurtis, 2016-10-21 17:27:50]

lgtm

[servolk, 2016-10-21 17:28:40]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2016-10-21 17:29:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 18:05:59]

Description was changed from

==========
Handle duplicate media track ids in FFmpegDemuxer

Previously we would just crash due to CHECK when we detected media
streams with duplicate bytestream ids. This CL adds explicit checks
for duplicate stream ids in FFmpegDemuxer and skips those streams.

BUG=657437
==========

to

==========
Handle duplicate media track ids in FFmpegDemuxer

Previously we would just crash due to CHECK when we detected media
streams with duplicate bytestream ids. This CL adds explicit checks
for duplicate stream ids in FFmpegDemuxer and skips those streams.

BUG=657437
==========

[commit-bot: I haz the power, 2016-10-21 18:06:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 18:11:52]

Description was changed from

==========
Handle duplicate media track ids in FFmpegDemuxer

Previously we would just crash due to CHECK when we detected media
streams with duplicate bytestream ids. This CL adds explicit checks
for duplicate stream ids in FFmpegDemuxer and skips those streams.

BUG=657437
==========

to

==========
Handle duplicate media track ids in FFmpegDemuxer

Previously we would just crash due to CHECK when we detected media
streams with duplicate bytestream ids. This CL adds explicit checks
for duplicate stream ids in FFmpegDemuxer and skips those streams.

BUG=657437

Committed: https://crrev.com/41ecabf2dc6286a0cc529cfe50eabe44c3a56c54
Cr-Commit-Position: refs/heads/master@{#426840}
==========

[commit-bot: I haz the power, 2016-10-21 18:11:54]

Patchset 3 (id:??) landed as
https://crrev.com/41ecabf2dc6286a0cc529cfe50eabe44c3a56c54
Cr-Commit-Position: refs/heads/master@{#426840}