scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json - Issue 2434353002: Change archive_retry_summary step to happen also when there are new failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json

Issue 2434353002: Change archive_retry_summary step to happen also when there are new failures. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/test_utils/api.py ('k') | scripts/slave/recipes/chromium_trybot.expected/too_many_failures_for_retcode.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json b/scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json

index cd29b35e82562e1076056f44474544108cc17e71..71b9cdc8c6458286cacc2cdbc776700ae3639a39 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json

@@ -721,7 +721,29 @@

"step returned non-zero exit code: 1",

"@@@STEP_TEXT@<br/>failures:<br/>bad/totally-bad-probably.html<br/>tricky/totally-maybe-not-awesome.html<br/>@@@",

"@@@STEP_FAILURE@@@",

- "@@@SET_BUILD_PROPERTY@failure_type@\"TEST_FAILURE\"@@@",

+ "@@@SET_BUILD_PROPERTY@failure_type@\"TEST_FAILURE\"@@@"

+ ]

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

+ "RECIPE_PACKAGE_REPO[build]/scripts/slave/chromium/archive_layout_test_retry_summary.py",

+ "--retry-summary-json",

+ "{\"failures\": [\"bad/totally-bad-probably.html\", \"tricky/totally-maybe-not-awesome.html\"], \"ignored\": []}",

+ "--build-number",

+ "571",

+ "--builder-name",

+ "linux_precise_blink_rel",

+ "--gs-bucket",

+ "gs://chromium-layout-test-archives"

+ ],

+ "cwd": "[BUILDER_CACHE]/linux_layout",

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

+ },

+ "name": "archive_retry_summary",

+ "~followup_annotations": [

"@@@SET_BUILD_PROPERTY@failure_hash@\"c3c333c07f535499b5146eecbf978c6b4f5b7535\"@@@"

]