Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: scripts/slave/recipe_modules/test_utils/api.py

Issue 2434353002: Change archive_retry_summary step to happen also when there are new failures. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine import recipe_api 5 from recipe_engine import recipe_api
6 from recipe_engine import util as recipe_util 6 from recipe_engine import util as recipe_util
7 7
8 from .util import GTestResults, TestResults 8 from .util import GTestResults, TestResults
9 9
10 # TODO(luqui): Destroy this DEPS hack. 10 # TODO(luqui): Destroy this DEPS hack.
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 if new_failures: 188 if new_failures:
189 self.m.python.failing_step(step_name, step_text) 189 self.m.python.failing_step(step_name, step_text)
190 else: 190 else:
191 self.m.python.succeeding_step(step_name, step_text) 191 self.m.python.succeeding_step(step_name, step_text)
192 finally: 192 finally:
193 if new_failures: 193 if new_failures:
194 self.m.tryserver.set_test_failure_tryjob_result() 194 self.m.tryserver.set_test_failure_tryjob_result()
195 elif ignored_failures: 195 elif ignored_failures:
196 self.m.step.active_result.presentation.status = self.m.step.WARNING 196 self.m.step.active_result.presentation.status = self.m.step.WARNING
197 197
198 if test.name == 'webkit_tests': 198 if test.name == 'webkit_tests':
199 self._archive_retry_summary({ 199 self._archive_retry_summary({
200 'failures': sorted(new_failures), 200 'failures': sorted(new_failures),
201 'ignored': sorted(ignored_failures) 201 'ignored': sorted(ignored_failures)
202 }) 202 })
203 203
204 def _archive_retry_summary(self, retry_summary): 204 def _archive_retry_summary(self, retry_summary):
205 """Archives the retry summary as JSON, storing it alongside the results 205 """Archives the retry summary as JSON, storing it alongside the results
206 from the first run.""" 206 from the first run."""
207 script = self.m.chromium.package_repo_resource( 207 script = self.m.chromium.package_repo_resource(
208 'scripts', 'slave', 'chromium', 'archive_layout_test_retry_summary.py') 208 'scripts', 'slave', 'chromium', 'archive_layout_test_retry_summary.py')
(...skipping 22 matching lines...) Expand all
231 def gtest_results(self, add_json_log=True): 231 def gtest_results(self, add_json_log=True):
232 """A placeholder which will expand to 232 """A placeholder which will expand to
233 '--test-launcher-summary-output=/tmp/file'. 233 '--test-launcher-summary-output=/tmp/file'.
234 234
235 Provides the --test-launcher-summary-output flag since --flag=value 235 Provides the --test-launcher-summary-output flag since --flag=value
236 (i.e. a single token in the command line) is the required format. 236 (i.e. a single token in the command line) is the required format.
237 237
238 The test_results will be an instance of the GTestResults class. 238 The test_results will be an instance of the GTestResults class.
239 """ 239 """
240 return GTestResultsOutputPlaceholder(self, add_json_log) 240 return GTestResultsOutputPlaceholder(self, add_json_log)
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698