Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2434343002: Revert of DevTools: properly restore selected DOMNode in Elements panel. (Closed)

Created:
4 years, 2 months ago by Mathieu
Modified:
4 years, 2 months ago
Reviewers:
dgozman, lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: properly restore selected DOMNode in Elements panel. (patchset #6 id:100001 of https://chromiumcodereview.appspot.com/2428823002/ ) Reason for revert: inspector/elements/elements-panel-restore-selection-when-node-comes-later.html failed on two bots (and perhaps more). One example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/5419/steps/webkit_tests Original issue's description: > DevTools: properly restore selected DOMNode in Elements panel. > > Since the http://crrev.com/b4d6bf98e, we started > sending two "documentUpdated" events for every > page reload. > > It's not a bad thing by itself (but probably needs > addressing in a follow-up), but the element restoration > logic is unprepared for this. > > This patch re-writes the element restoring logic in the > elements panel. > > BUG=645645 TBR=pfeldman@chromium.org,dgozman@chromium.org,lushnikov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645645 Committed: https://crrev.com/33eab73eaa7dc9020ca00a3fe1bcbf7ab131e0a0 Cr-Commit-Position: refs/heads/master@{#426577}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
Mathieu
Created Revert of DevTools: properly restore selected DOMNode in Elements panel.
4 years, 2 months ago (2016-10-20 20:10:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434343002/1
4 years, 2 months ago (2016-10-20 20:11:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 20:12:38 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:21:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33eab73eaa7dc9020ca00a3fe1bcbf7ab131e0a0
Cr-Commit-Position: refs/heads/master@{#426577}

Powered by Google App Engine
This is Rietveld 408576698