Add isEncoded to SkImageGenerator

Add isEncoded to SkImageGenerator

From within getDeferredTextureImageData() we want to know if the SkImage
is backed by an encoded image or not. We decided to add isEncoded to the
SkImage. However, the SkImage then needs to query the SkImageGenerator.

In order to land this change, 3 separate patches are needed to not break
the build.

This patch must land first. It allows image generators to override
isEncoded.

The second patch will be in Chrome, where its DecodingImageGenerators
will override isEncoded.

The third patch will then change getDeferredTextureImageData() to query
isEncoded.

BUG=646089
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2434323002

[cblume, 2016-10-20 19:01:55]

Description was changed from

==========
Add isEncoded to SkImageGenerator

From within getDeferredTextureImageData() we want to know if the SkImage
is backed by an encoded image or not. We decided to add isEncoded to the
SkImage. However, the SkImage then needs to query the SkImageGenerator.

In order to land this change, 3 separate patches are needed to not break
the build.

This patch must land first. It allows image generators to override
isEncoded.

The second patch will be in Chrome, where its DecodingImageGenerators
will override isEncoded.

The third patch will then change getDeferredTextureImageData() to query
isEncoded.

BUG=646089
==========

to

==========
Add isEncoded to SkImageGenerator

From within getDeferredTextureImageData() we want to know if the SkImage
is backed by an encoded image or not. We decided to add isEncoded to the
SkImage. However, the SkImage then needs to query the SkImageGenerator.

In order to land this change, 3 separate patches are needed to not break
the build.

This patch must land first. It allows image generators to override
isEncoded.

The second patch will be in Chrome, where its DecodingImageGenerators
will override isEncoded.

The third patch will then change getDeferredTextureImageData() to query
isEncoded.

BUG=646089
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2434323002
==========

[cblume, 2016-10-20 19:03:24]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 19:03:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cblume, 2016-10-20 19:04:29]

cblume@chromium.org changed reviewers:
+ bsalomon@google.com, vmpstr@chromium.org

[cblume, 2016-10-20 19:04:30]

PTAL

This is part of https://codereview.chromium.org/2337803002/ which will need to
be landed in 3 pieces. First this, then the Chrome side, then the final call
into isEncoded.

[cblume, 2016-10-20 19:08:39]

https://chromiumcodereview.appspot.com/2434323002/diff/1/include/core/SkImage...
File include/core/SkImageGenerator.h (right):

https://chromiumcodereview.appspot.com/2434323002/diff/1/include/core/SkImage...
include/core/SkImageGenerator.h:75: bool isEncoded() const { return
this->onIsEncoded(); }
Note that this is adding a function to the public API.
I know we would prefer to change the public API as little as possible. If there
is a better alternative I'm happy to do that.

[bsalomon, 2016-10-20 19:17:04]

bsalomon@google.com changed reviewers:
+ msarett@google.com, reed@google.com, scroggo@google.com

[bsalomon, 2016-10-20 19:17:05]

Deferring to others. I'm not too familiar with this code.

[commit-bot: I haz the power, 2016-10-20 19:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 19:26:42]

Dry run: This issue passed the CQ dry run.

[cblume, 2016-10-21 09:14:04]

I believe this is no longer needed.
A better alternative was made: https://skia-review.googlesource.com/c/3780/

I will close this issue.

[cblume, 2016-10-21 09:14:11]

Description was changed from

==========
Add isEncoded to SkImageGenerator

From within getDeferredTextureImageData() we want to know if the SkImage
is backed by an encoded image or not. We decided to add isEncoded to the
SkImage. However, the SkImage then needs to query the SkImageGenerator.

In order to land this change, 3 separate patches are needed to not break
the build.

This patch must land first. It allows image generators to override
isEncoded.

The second patch will be in Chrome, where its DecodingImageGenerators
will override isEncoded.

The third patch will then change getDeferredTextureImageData() to query
isEncoded.

BUG=646089
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2434323002
==========

to

==========
Add isEncoded to SkImageGenerator

From within getDeferredTextureImageData() we want to know if the SkImage
is backed by an encoded image or not. We decided to add isEncoded to the
SkImage. However, the SkImage then needs to query the SkImageGenerator.

In order to land this change, 3 separate patches are needed to not break
the build.

This patch must land first. It allows image generators to override
isEncoded.

The second patch will be in Chrome, where its DecodingImageGenerators
will override isEncoded.

The third patch will then change getDeferredTextureImageData() to query
isEncoded.

BUG=646089
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2434323002
==========