Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2434143003: [ios] Adds GoogleLogoService to help with fetching doodles. (Closed)

Created:
4 years, 2 months ago by rohitrao (ping after 24h)
Modified:
4 years, 2 months ago
Reviewers:
reed2, *sdefresne, *justincohen, reed1
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds GoogleLogoService to help with fetching doodles. BUG=656617 Committed: https://crrev.com/3152599bcce134b11eb8b6c5229bc8d4fd772e70 Cr-Commit-Position: refs/heads/master@{#426795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -28 lines) Patch
M ios/chrome/browser/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M ios/chrome/browser/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm View 2 chunks +2 lines, -0 lines 0 comments Download
A ios/chrome/browser/google/google_logo_service.h View 1 chunk +52 lines, -0 lines 0 comments Download
A ios/chrome/browser/google/google_logo_service.mm View 1 chunk +131 lines, -0 lines 0 comments Download
A + ios/chrome/browser/google/google_logo_service_factory.h View 2 chunks +15 lines, -15 lines 0 comments Download
A + ios/chrome/browser/google/google_logo_service_factory.mm View 1 chunk +14 lines, -13 lines 0 comments Download

Messages

Total messages: 26 (14 generated)
rohitrao (ping after 24h)
The implementation of this service felt Google-specific, so I named it accordingly. Renaming helps me ...
4 years, 2 months ago (2016-10-20 02:58:39 UTC) #5
justincohen
name change rs lgtm
4 years, 2 months ago (2016-10-20 14:39:41 UTC) #8
sdefresne
lgtm
4 years, 2 months ago (2016-10-20 18:53:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434143003/1
4 years, 2 months ago (2016-10-20 22:06:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/286392)
4 years, 2 months ago (2016-10-20 22:30:51 UTC) #13
rohitrao (ping after 24h)
+reed for OWNERS approval to add SkBitmap.h in ios/chrome/browser/DEPS. Thanks!
4 years, 2 months ago (2016-10-20 22:37:58 UTC) #15
rohitrao (ping after 24h)
Also +bsalomon, because I can't tell if reed is OOO today =)
4 years, 2 months ago (2016-10-21 13:25:39 UTC) #17
reed1
lgtm boy do we need to update gfx to use SkImages ...
4 years, 2 months ago (2016-10-21 13:27:51 UTC) #19
rohitrao (ping after 24h)
Thanks for the review! Happy to chat about skia on iOS anytime =)
4 years, 2 months ago (2016-10-21 13:30:07 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434143003/1
4 years, 2 months ago (2016-10-21 13:30:23 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 15:12:24 UTC) #24
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 15:34:07 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3152599bcce134b11eb8b6c5229bc8d4fd772e70
Cr-Commit-Position: refs/heads/master@{#426795}

Powered by Google App Engine
This is Rietveld 408576698