Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: client/run_isolated.py

Issue 2434133003: run_isolated: rename cache to isolate_cache (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/run_isolated.py
diff --git a/client/run_isolated.py b/client/run_isolated.py
index 0306c1953193b1f3c8482b149c27f1fbaca3ce02..7c3f063793c8f1356e4ceeb5697043fed212788a 100755
--- a/client/run_isolated.py
+++ b/client/run_isolated.py
@@ -510,7 +510,7 @@ def map_and_run(
def run_tha_test(
- command, isolated_hash, storage, cache, leak_temp_dir, result_json,
+ command, isolated_hash, storage, isolate_cache, leak_temp_dir, result_json,
root_dir, hard_timeout, grace_period, bot_file, extra_args,
install_packages_fn, use_symlinks):
"""Runs an executable and records execution metadata.
@@ -535,9 +535,9 @@ def run_tha_test(
storage: an isolateserver.Storage object to retrieve remote objects. This
object has a reference to an isolateserver.StorageApi, which does
the actual I/O.
- cache: an isolateserver.LocalCache to keep from retrieving the same objects
- constantly by caching the objects retrieved. Can be on-disk or
- in-memory.
+ isolate_cache: an isolateserver.LocalCache to keep from retrieving the
+ same objects constantly by caching the objects retrieved.
+ Can be on-disk or in-memory.
leak_temp_dir: if true, the temporary directory will be deliberately leaked
for later examination.
result_json: file path to dump result metadata into. If set, the process
@@ -575,7 +575,7 @@ def run_tha_test(
# run_isolated exit code. Depends on if result_json is used or not.
result = map_and_run(
- command, isolated_hash, storage, cache, leak_temp_dir, root_dir,
+ command, isolated_hash, storage, isolate_cache, leak_temp_dir, root_dir,
hard_timeout, grace_period, bot_file, extra_args, install_packages_fn,
use_symlinks)
logging.info('Result:\n%s', tools.format_json(result, dense=True))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698