Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2434053002: Android: tuning Exynos HW H264 encoding performance. (Closed)

Created:
4 years, 2 months ago by braveyao
Modified:
4 years, 2 months ago
Reviewers:
watk
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, agrieve+watch_chromium.org, piman+watch_chromium.org, mlamouri+watch-media_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: tuning Exynos HW H264 encoding performance. Exynos H.264 HW encoder implementation assumes constant frame rate and does not adjust when actual frame rate is different from the original value. For example, when encoder is intialized with 30fps and we want to adapt to 1000kbps@15fps now, we will only get 500kbps@15fps. So we will adjust the target bps to 2000kbps@15fps to achieve the expected 1000kbps. BUG=615108 Committed: https://crrev.com/24fb7732dd44b585fac9dd46d5a04678f6eece6c Cr-Commit-Position: refs/heads/master@{#426361}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -22 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 7 chunks +29 lines, -8 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecUtil.java View 1 7 chunks +48 lines, -8 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/sdk_media_codec_bridge.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/gpu/android_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
braveyao
Hi watk@, This is a following cl to https://codereview.chromium.org/2358683002/. Please take a look.
4 years, 2 months ago (2016-10-19 20:51:37 UTC) #6
watk
lgtm https://chromiumcodereview.appspot.com/2434053002/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecUtil.java File media/base/android/java/src/org/chromium/media/MediaCodecUtil.java (right): https://chromiumcodereview.appspot.com/2434053002/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecUtil.java#newcode431 media/base/android/java/src/org/chromium/media/MediaCodecUtil.java:431: HWEncoderProperties encoderProperty = findHWEncoder(mime); encoderProperties?
4 years, 2 months ago (2016-10-19 21:01:50 UTC) #7
braveyao
Thanks so much! https://chromiumcodereview.appspot.com/2434053002/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecUtil.java File media/base/android/java/src/org/chromium/media/MediaCodecUtil.java (right): https://chromiumcodereview.appspot.com/2434053002/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecUtil.java#newcode431 media/base/android/java/src/org/chromium/media/MediaCodecUtil.java:431: HWEncoderProperties encoderProperty = findHWEncoder(mime); On 2016/10/19 ...
4 years, 2 months ago (2016-10-19 23:35:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434053002/20001
4 years, 2 months ago (2016-10-19 23:36:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 01:05:35 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:14:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24fb7732dd44b585fac9dd46d5a04678f6eece6c
Cr-Commit-Position: refs/heads/master@{#426361}

Powered by Google App Engine
This is Rietveld 408576698