Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2434033003: Clean up LayoutTableSection::calcRowLogicalHeight() a bit. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up LayoutTableSection::calcRowLogicalHeight() a bit. Since nobody apparently wants to deal with a rowspanned cell unless we're at its first row, just skip that cell for subsequent rows, instead of having checks for this everywhere. Also removed a debug hashmap that was just used to assert that we didn't add duplicate cells to a vector. Check the vector directly instead. Committed: https://crrev.com/cc645344ea206b9bf3df064054fec1b7a734d38c Cr-Commit-Position: refs/heads/master@{#426555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 3 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-20 14:24:57 UTC) #6
eae
LGTM
4 years, 2 months ago (2016-10-20 16:56:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434033003/1
4 years, 2 months ago (2016-10-20 18:59:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 19:08:13 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:21:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc645344ea206b9bf3df064054fec1b7a734d38c
Cr-Commit-Position: refs/heads/master@{#426555}

Powered by Google App Engine
This is Rietveld 408576698