Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2434003003:
[autofill] Update autofill address rewriter rules. (Closed)
|
Created:
4 years, 2 months ago by Roger McFarlane (Chromium) Modified:
4 years, 1 month ago CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[autofill] Update autofill address rewriter rules.
Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order.
BUG=620414, 658303
Committed: https://crrev.com/4bad57e09d4f88da3b7a296b90980d464a942b87
Cr-Commit-Position: refs/heads/master@{#426861}
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Patchset #1 (id:1) has been deleted
rogerm@chromium.org changed reviewers: + mathp@google.com
PTAL? Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are not sorted on order of decreasing length and then in lexicographical order.
Description was changed from ========== [autofill] Update autofill address rewriter rules. BUG=620414 ========== to ========== [autofill] Update autofill address rewriter rules. Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order. BUG=620414 ==========
mathp@chromium.org changed reviewers: + mathp@chromium.org
Thanks. Don't forget to leave behind some doc as to how to his generated. lgtm
mathp@chromium.org changed reviewers: - mathp@chromium.org
On 2016/10/20 21:04:15, Mathieu Perreault wrote: > Thanks. Don't forget to leave behind some doc as to how to his generated. lgtm Also if you could have a specific bug for this so it's more easily mergeable.
Description was changed from ========== [autofill] Update autofill address rewriter rules. Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order. BUG=620414 ========== to ========== [autofill] Update autofill address rewriter rules. Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order. BUG=620414, 658303 ==========
On 2016/10/21 16:59:03, Mathieu Perreault wrote: > On 2016/10/20 21:04:15, Mathieu Perreault wrote: > > Thanks. Don't forget to leave behind some doc as to how to his generated. lgtm > > Also if you could have a specific bug for this so it's more easily mergeable. Added crbug.com/658c03
On 2016/10/21 17:13:29, Roger McFarlane (Chromium) wrote: > On 2016/10/21 16:59:03, Mathieu Perreault wrote: > > On 2016/10/20 21:04:15, Mathieu Perreault wrote: > > > Thanks. Don't forget to leave behind some doc as to how to his generated. > lgtm > > > > Also if you could have a specific bug for this so it's more easily mergeable. > > Added crbug.com/658c03 arg... crbug.com/658303
The CQ bit was checked by rogerm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [autofill] Update autofill address rewriter rules. Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order. BUG=620414, 658303 ========== to ========== [autofill] Update autofill address rewriter rules. Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order. BUG=620414, 658303 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [autofill] Update autofill address rewriter rules. Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order. BUG=620414, 658303 ========== to ========== [autofill] Update autofill address rewriter rules. Most if the changes are due to sort order of the rules, which has now been more fully specified. The rules used to be in order of decreasing length, with unspecified order for rules of the same length. Rules are now sorted on order of decreasing length and then in lexicographical order. BUG=620414, 658303 Committed: https://crrev.com/4bad57e09d4f88da3b7a296b90980d464a942b87 Cr-Commit-Position: refs/heads/master@{#426861} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4bad57e09d4f88da3b7a296b90980d464a942b87 Cr-Commit-Position: refs/heads/master@{#426861} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
