Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2434003002: AudioRendererImpl: Fix data race. (Closed)

Created:
4 years, 2 months ago by chcunningham
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, DaleCurtis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AudioRendererImpl: Fix data race. Previous CL introduced multithreaded access to |rendering_|. https://codereview.chromium.org/2423903003/ BUG=657001, 648710 Committed: https://crrev.com/e2f429e24bdbcd8e8379b909879e2c729490e1c6 Cr-Commit-Position: refs/heads/master@{#426312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M media/renderers/audio_renderer_impl.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
chcunningham
Hey Dale, worried I'm missing something here - why was rendering_ intentionally accessed/set outside the ...
4 years, 2 months ago (2016-10-19 17:17:16 UTC) #2
DaleCurtis
Sorry, don't remember, it's probably because it was only used on the main thread previously.
4 years, 2 months ago (2016-10-19 17:21:29 UTC) #3
chcunningham
On 2016/10/19 17:21:29, DaleCurtis wrote: > Sorry, don't remember, it's probably because it was only ...
4 years, 2 months ago (2016-10-19 18:19:00 UTC) #5
sandersd (OOO until July 31)
lgtm
4 years, 2 months ago (2016-10-19 18:20:25 UTC) #6
chcunningham
Thanks Dan
4 years, 2 months ago (2016-10-19 18:30:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434003002/1
4 years, 2 months ago (2016-10-19 18:32:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/319798)
4 years, 2 months ago (2016-10-19 19:50:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2434003002/1
4 years, 2 months ago (2016-10-19 20:45:08 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 22:41:32 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:12:26 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2f429e24bdbcd8e8379b909879e2c729490e1c6
Cr-Commit-Position: refs/heads/master@{#426312}

Powered by Google App Engine
This is Rietveld 408576698