Fix opening App Menu after Bookmarks Drag

Fix opening App Menu after Bookmarks Drag

After dragging a nested bookmarks folder to the bookmarks bar, you could not
open the App Menu.

During a Drag operation BookmarkBarView can call Cancel in several
circumstances. If a Cancel was received by MenuController before
OnDragCompleted. Then the internal call to Cancel would not properly teardown
the menu. With an active, but hidden, menu new menus, such as the AppMenu, could
not launch.

This change updates the logic of MenuController::OnDragCompleted to make sure
that teardown occurs.

TEST=MenuControllerTest.AsynchronousDragComplete, MenuControllerTest.AsynchronousCancelDuringDrag
BUG=656948
Committed: https://crrev.com/6f08e5ae5e67d68510072d6873366a06841064fe
Cr-Commit-Position: refs/heads/master@{#426592}

[jonross, 2016-10-19 20:39:47]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 20:40:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:22:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:22:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jonross, 2016-10-20 17:54:40]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 17:55:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 19:15:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 19:15:47]

Dry run: This issue passed the CQ dry run.

[jonross, 2016-10-20 19:38:56]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-10-20 19:38:57]

Hey sky@

A few interesting shutdown/cancellation cases for drag-and-drop where found.
I've updated MenuController to address these.

Could you take a look?

Thanks,
Jon

[sky, 2016-10-20 20:45:45]

LGTM

[jonross, 2016-10-20 20:46:54]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-10-20 20:47:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 21:00:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:22:22]

Description was changed from

==========
Fix opening App Menu after Bookmarks Drag

After dragging a nested bookmarks folder to the bookmarks bar, you could not
open the App Menu.

During a Drag operation BookmarkBarView can call Cancel in several
circumstances. If a Cancel was received by MenuController before
OnDragCompleted. Then the internal call to Cancel would not properly teardown
the menu. With an active, but hidden, menu new menus, such as the AppMenu, could
not launch.

This change updates the logic of MenuController::OnDragCompleted to make sure
that teardown occurs.

TEST=MenuControllerTest.AsynchronousDragComplete,
MenuControllerTest.AsynchronousCancelDuringDrag
BUG=656948
==========

to

==========
Fix opening App Menu after Bookmarks Drag

After dragging a nested bookmarks folder to the bookmarks bar, you could not
open the App Menu.

During a Drag operation BookmarkBarView can call Cancel in several
circumstances. If a Cancel was received by MenuController before
OnDragCompleted. Then the internal call to Cancel would not properly teardown
the menu. With an active, but hidden, menu new menus, such as the AppMenu, could
not launch.

This change updates the logic of MenuController::OnDragCompleted to make sure
that teardown occurs.

TEST=MenuControllerTest.AsynchronousDragComplete,
MenuControllerTest.AsynchronousCancelDuringDrag
BUG=656948

Committed: https://crrev.com/6f08e5ae5e67d68510072d6873366a06841064fe
Cr-Commit-Position: refs/heads/master@{#426592}
==========

[commit-bot: I haz the power, 2016-10-21 13:22:23]

Patchset 2 (id:??) landed as
https://crrev.com/6f08e5ae5e67d68510072d6873366a06841064fe
Cr-Commit-Position: refs/heads/master@{#426592}