Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Issue 2433933006: Changing data_use_measurement/OWNERS to redirect to DRP (Closed)

Created:
4 years, 2 months ago by RyanSturm
Modified:
4 years, 1 month ago
Reviewers:
bengr
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changing data_use_measurement/OWNERS to redirect to DRP src/components/data_use_measurement/OWNERS points to a subset of OWNERS in src/components/data_reduction_proxy/OWNERS, but should include all of the OWNERS. BUG=657616 Committed: https://crrev.com/98d735da9c58231b0622ec757ee1b9a96c994b32 Cr-Commit-Position: refs/heads/master@{#426298}

Patch Set 1 #

Patch Set 2 : other OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/browser/data_use_measurement/OWNERS View 1 1 chunk +1 line, -3 lines 0 comments Download
M components/data_use_measurement/OWNERS View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
RyanSturm
bengr: PTAL
4 years, 2 months ago (2016-10-19 21:02:54 UTC) #6
bengr
lgtm. In general, have every CL, even trivial ones, reference a bug. It makes it ...
4 years, 2 months ago (2016-10-19 21:04:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433933006/20001
4 years, 2 months ago (2016-10-19 21:39:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 21:58:38 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-21 13:11:56 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98d735da9c58231b0622ec757ee1b9a96c994b32
Cr-Commit-Position: refs/heads/master@{#426298}

Powered by Google App Engine
This is Rietveld 408576698