Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2433933005: [heap] Add a guard for restarting the memory reducer after mark-compact. (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add a guard for restarting the memory reducer after mark-compact. Currently it is possible to get into a cycle of mark-compact -> memory reducer -> mark-compact -> memory reducer ... where the memory reducer does not free memory. This patch ensures that the memory reducer restarts only if the committed memory increased by sufficient amount after the last run. BUG= Committed: https://crrev.com/0a82f091106e5404ac9bcd515ca1d8152bf38604 Cr-Commit-Position: refs/heads/master@{#40457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -34 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/memory-reducer.h View 4 chunks +12 lines, -3 lines 0 comments Download
M src/heap/memory-reducer.cc View 6 chunks +29 lines, -12 lines 0 comments Download
M test/unittests/heap/memory-reducer-unittest.cc View 9 chunks +51 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ulan
ptal
4 years, 2 months ago (2016-10-19 18:33:10 UTC) #2
Hannes Payer (out of office)
lgtm
4 years, 2 months ago (2016-10-20 07:21:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433933005/1
4 years, 2 months ago (2016-10-20 08:38:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 09:04:04 UTC) #6
davidroutier17
On 2016/10/20 07:21:21, Hannes Payer wrote: > lgtm CC
4 years, 2 months ago (2016-10-20 09:36:26 UTC) #7
davidroutier17
Normal
4 years, 2 months ago (2016-10-21 12:05:05 UTC) #9
ulan
A revert of this CL (patchset #1 id:1) has been created in https://chromiumcodereview.appspot.com/2472053003/ by ulan@chromium.org. ...
4 years, 1 month ago (2016-11-03 16:16:13 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a82f091106e5404ac9bcd515ca1d8152bf38604
Cr-Commit-Position: refs/heads/master@{#40457}

Powered by Google App Engine
This is Rietveld 408576698