Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 2433923005: Revert of Expose RTT and throughput estimates from Cronet (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index 584d519cac91e7399db1957ca60e46756e2f0222..1e433d90b421694647c8879178a37bb272a7adc3 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -11,8 +11,6 @@
import android.os.Looper;
import android.os.StrictMode;
import android.test.suitebuilder.annotation.SmallTest;
-
-import org.json.JSONObject;
import org.chromium.base.FileUtils;
import org.chromium.base.PathUtils;
@@ -23,6 +21,7 @@
import org.chromium.net.impl.CronetLibraryLoader;
import org.chromium.net.impl.CronetUrlRequestContext;
import org.chromium.net.test.EmbeddedTestServer;
+import org.json.JSONObject;
import java.io.BufferedReader;
import java.io.File;
@@ -281,8 +280,6 @@
@Feature({"Cronet"})
public void testRealTimeNetworkQualityObservationsQuicDisabled() throws Exception {
CronetEngine.Builder mCronetEngineBuilder = new CronetEngine.Builder(getContext());
- assert RttThroughputValues.INVALID_RTT_THROUGHPUT < 0;
-
Executor listenersExecutor = Executors.newSingleThreadExecutor(new ExecutorThreadFactory());
ConditionVariable waitForThroughput = new ConditionVariable();
TestNetworkQualityRttListener rttListener =
@@ -332,22 +329,6 @@
// effective connection type is correctly set.
assertTrue(testFramework.mCronetEngine.getEffectiveConnectionType()
!= EffectiveConnectionType.TYPE_UNKNOWN);
-
- // Verify that the HTTP RTT, transport RTT and downstream throughput
- // estimates are available.
- if (testFramework.mCronetEngine.getEffectiveConnectionType()
- != EffectiveConnectionType.TYPE_OFFLINE) {
- assertTrue(testFramework.mCronetEngine.getHttpRttMs() > 0);
- assertTrue(testFramework.mCronetEngine.getTransportRttMs() > 0);
- assertTrue(testFramework.mCronetEngine.getDownstreamThroughputKbps() > 0);
- } else {
- assertEquals(RttThroughputValues.INVALID_RTT_THROUGHPUT,
- testFramework.mCronetEngine.getHttpRttMs());
- assertEquals(RttThroughputValues.INVALID_RTT_THROUGHPUT,
- testFramework.mCronetEngine.getTransportRttMs());
- assertEquals(RttThroughputValues.INVALID_RTT_THROUGHPUT,
- testFramework.mCronetEngine.getDownstreamThroughputKbps());
- }
testFramework.mCronetEngine.shutdown();
}
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java ('k') | net/nqe/network_quality.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698