Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2433923005: Revert of Expose RTT and throughput estimates from Cronet (Closed)

Created:
4 years, 2 months ago by tbansal1
Modified:
4 years, 2 months ago
Reviewers:
RyanSturm, mgersh, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Expose RTT and throughput estimates from Cronet (patchset #7 id:240001 of https://codereview.chromium.org/2417643007/ ) Reason for revert: Reverting this due to trybot failures: https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARM64%20Builder%20%28dbg%29/builds/40129 Original issue's description: > Expose RTT and throughput estimates from Cronet > > The estimates are computed by the network quality estimator > (NQE) and are pushed to CronetUrlRequestContext. > > Embedders can query for the estimates by calling > appropriate methods on CronetEngine. > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.android:android_cronet > > BUG=654498 TBR=ryansturm@chromium.org,mgersh@chromium.org,xunjieli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654498 Committed: https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51 Cr-Commit-Position: refs/heads/master@{#426522}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -196 lines) Patch
M components/cronet/android/BUILD.gn View 4 chunks +1 line, -12 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 1 chunk +0 lines, -36 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java View 1 chunk +0 lines, -15 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.h View 2 chunks +0 lines, -8 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java View 4 chunks +3 lines, -63 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 4 chunks +1 line, -20 lines 0 comments Download
M net/nqe/network_quality.h View 1 chunk +1 line, -13 lines 0 comments Download
M net/nqe/network_quality.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 3 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tbansal1
Created Revert of Expose RTT and throughput estimates from Cronet
4 years, 2 months ago (2016-10-20 17:34:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433923005/1
4 years, 2 months ago (2016-10-20 17:35:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 17:36:27 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:19:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8ec19e9790339b41d4000db65fec00205f81a51
Cr-Commit-Position: refs/heads/master@{#426522}

Powered by Google App Engine
This is Rietveld 408576698