Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2433873005: cros: Use "regular" extension session type for child users (Closed)

Created:
4 years, 2 months ago by xiyuan
Modified:
4 years, 2 months ago
Reviewers:
tbarzic
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Use "regular" extension session type for child users Test failures in http://crbug.com/657180 reveal a problem of what session type to use for users changing the child status from the extension feature's perspective. This is a valid case as the child status of a user could change when the user's Gaia account is updated. Since child users are allowed to use extensions as regular users, use "regular" extension session type for them too. Also re-enable the tests. BUG=657180 Committed: https://crrev.com/4b2c7bf96730778554c4978e8103545965bdec22 Cr-Commit-Position: refs/heads/master@{#426284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
xiyuan
4 years, 2 months ago (2016-10-19 19:30:06 UTC) #2
tbarzic
lgtm
4 years, 2 months ago (2016-10-19 19:40:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433873005/1
4 years, 2 months ago (2016-10-19 20:47:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 21:11:51 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:11:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b2c7bf96730778554c4978e8103545965bdec22
Cr-Commit-Position: refs/heads/master@{#426284}

Powered by Google App Engine
This is Rietveld 408576698