Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: third_party/WebKit/Source/core/layout/ScrollAnchor.h

Issue 2433873003: Fix crash when calling ScrollAnchor::clear from PaintLayer's destructor (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ScrollAnchor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ScrollAnchor.h
diff --git a/third_party/WebKit/Source/core/layout/ScrollAnchor.h b/third_party/WebKit/Source/core/layout/ScrollAnchor.h
index 1490c6f7ef7f06e3afa93356ba1684003f07b758..d3333ba947d2db528fd8910cf7b20f40e8c60a4d 100644
--- a/third_party/WebKit/Source/core/layout/ScrollAnchor.h
+++ b/third_party/WebKit/Source/core/layout/ScrollAnchor.h
@@ -38,6 +38,10 @@ class CORE_EXPORT ScrollAnchor final {
// containing scroller and all ancestor scrollers.
void clear();
+ // Indicates that the next save() should compute a new anchor for the
+ // containing scroller.
+ void clearSelf();
+
// Records the anchor's location in relation to the scroller. Should be
// called when the scroller is about to be laid out.
void save();
@@ -64,9 +68,9 @@ class CORE_EXPORT ScrollAnchor final {
DEFINE_INLINE_TRACE() { visitor->trace(m_scroller); }
private:
- // Indicates that the next save() should compute a new anchor for the
- // containing scroller.
- void clearSelf(bool unconditionally = false);
+ // Releases the anchor and conditionally clears the IsScrollAnchorObject bit
+ // on the LayoutObject.
+ void clearSelf(bool unconditionally);
void findAnchor();
bool computeScrollAnchorDisablingStyleChanged();
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ScrollAnchor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698