Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2433823003: Further refine div output when a div receives focus (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Further refine div output when a div receives focus This cl makes div output the same way as classic: - when a div receives either ChromeVox or page focus, read its text content or its aria label - this cleans up output and retains the previously hardened behavior in Classic. TEST=browse on a variety of sites like Gmail, Groups. Verify that despite bad markup, ChromeVox performs well and provides a smooth experience. BUG=619279 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65 Cr-Commit-Position: refs/heads/master@{#426497}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 4 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
David Tseng
This makes https://codereview.chromium.org/2390763002/ obsolete.
4 years, 2 months ago (2016-10-19 18:25:29 UTC) #3
dmazzoni
lgtm https://codereview.chromium.org/2433823003/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js (right): https://codereview.chromium.org/2433823003/diff/1/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#newcode450 chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:450: speak: '$textContent $description' This is similar to nameOrDescendants ...
4 years, 2 months ago (2016-10-19 19:56:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433823003/20001
4 years, 2 months ago (2016-10-20 15:26:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 16:37:40 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0026818d58dc22ebea46fe8ff31456aa0ac7bf65 Cr-Commit-Position: refs/heads/master@{#426497}
4 years, 2 months ago (2016-10-21 13:18:57 UTC) #12
Mathieu
4 years, 2 months ago (2016-10-21 15:46:34 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://chromiumcodereview.appspot.com/2443603002/ by mathp@chromium.org.

The reason for reverting is: Speculative revert to fix failing bots

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

.

Powered by Google App Engine
This is Rietveld 408576698