git cl: refactor direct usage of time.sleep and time.time.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from __future__ import print_function
 
 from distutils.version import LooseVersion
 from multiprocessing.pool import ThreadPool
 import base64
 import collections
 import httplib
 import json
 import logging
 import multiprocessing
 import optparse
 import os
 import re
 import stat
 import sys
 import textwrap
-import time
 import traceback
 import urllib
 import urllib2
 import urlparse
 import uuid
 import webbrowser
 import zlib
 
 try:
   import readline  # pylint: disable=F0401,W0611
@@ skipping 104 matching lines @@
       LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
 
 
 def BranchExists(branch):
   """Return True if specified branch exists."""
   code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
                            suppress_stderr=True)
   return not code
 
 
+def time_sleep(seconds):
+  # Use this so that it can be mocked in tests without interfering with python
+  # system machinery.
+  import time  # Local import to discourage others from importing time globally.
+  return time.sleep(seconds)
+
+
 def ask_for_data(prompt):
   try:
     return raw_input(prompt)
   except KeyboardInterrupt:
     # Hide the exception.
     sys.exit(1)
 
 
 def _git_branch_config_key(branch, key):
   """Helper method to return Git config key for a branch."""
@@ skipping 145 matching lines @@
         raise BuildbucketResponseException(
             'Buildbucket returns invalid json content: %s.\n'
             'Please file bugs at http://crbug.com, label "Infra-BuildBucket".' %
             content)
       return content_json
     if response.status < 500 or try_count >= 2:
       raise httplib2.HttpLib2Error(content)
 
     # status >= 500 means transient failures.
     logging.debug('Transient errors when %s. Will retry.', operation_name)
-    time.sleep(0.5 + 1.5*try_count)
+    time_sleep(0.5 + 1.5*try_count)
     try_count += 1
   assert False, 'unreachable'
 
 
 def _trigger_try_jobs(auth_config, changelist, masters, options,
                       category='git_cl_try', patchset=None):
   assert changelist.GetIssue(), 'CL must be uploaded first'
   codereview_url = changelist.GetCodereviewServer()
   assert codereview_url, 'CL must be uploaded first'
   patchset = patchset or changelist.GetMostRecentPatchset()
@@ skipping 5046 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   setup_color.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)