Generalize Previews Type code

Generalize Previews Type code

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=615564
TBR=dimich

Committed: https://crrev.com/72a715afdc50e013d0c96a2042ecb3e86b428d08
Cr-Commit-Position: refs/heads/master@{#426932}

[RyanSturm, 2016-10-19 18:18:19]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 18:18:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 18:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 18:32:55]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[RyanSturm, 2016-10-19 19:53:56]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 19:54:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 20:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 20:08:39]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[RyanSturm, 2016-10-19 20:15:41]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[RyanSturm, 2016-10-19 20:16:09]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-10-19 20:16:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 22:28:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:28:11]

Dry run: This issue passed the CQ dry run.

[RyanSturm, 2016-10-19 23:31:10]

ryansturm@chromium.org changed reviewers:
+ tbansal@chromium.org

[RyanSturm, 2016-10-19 23:31:11]

tbansal: PTAL

[RyanSturm, 2016-10-19 23:31:18]

Description was changed from

==========
Generalize Previews Type code

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=
==========

to

==========
Generalize Previews Type code

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=615564
==========

[tbansal1, 2016-10-21 16:17:20]

lgtm % nit.

https://codereview.chromium.org/2433793003/diff/40001/components/previews/cor...
File components/previews/core/previews_experiments.cc (right):

https://codereview.chromium.org/2433793003/diff/40001/components/previews/cor...
components/previews/core/previews_experiments.cc:118: return false;
Add NOTREACHED() in default?

[RyanSturm, 2016-10-21 22:09:37]

Description was changed from

==========
Generalize Previews Type code

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=615564
==========

to

==========
Generalize Previews Type code

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=615564

TBR=dimich
==========

[RyanSturm, 2016-10-21 22:10:52]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 22:11:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2016-10-21 22:11:23]

dimich: PTAL at the header change, TBR'd because there is no functional change.

[RyanSturm, 2016-10-21 22:11:37]

ryansturm@chromium.org changed reviewers:
+ dimich@chromium.org

[RyanSturm, 2016-10-21 22:11:45]

The CQ bit was unchecked by ryansturm@chromium.org

[RyanSturm, 2016-10-21 22:11:48]

The CQ bit was checked by ryansturm@chromium.org

[RyanSturm, 2016-10-21 22:11:49]

The patchset sent to the CQ was uploaded after l-g-t-m from tbansal@chromium.org
Link to the patchset: https://codereview.chromium.org/2433793003/#ps60001
(title: "tbansal comment")

[commit-bot: I haz the power, 2016-10-21 22:12:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-22 00:12:09]

Description was changed from

==========
Generalize Previews Type code

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=615564

TBR=dimich
==========

to

==========
Generalize Previews Type code

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=615564

TBR=dimich
==========

[commit-bot: I haz the power, 2016-10-22 00:12:10]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-22 00:15:13]

Description was changed from

==========
Generalize Previews Type code

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=615564

TBR=dimich
==========

to

==========
Generalize Previews Type code

This moves PreviewType to previews_experiments.h and chagnes
IsOfflinePreviewsEnabled to IsPreviewsTypeEnabled to allow other
previews to use the code in a similar fashion.

BUG=615564

TBR=dimich

Committed: https://crrev.com/72a715afdc50e013d0c96a2042ecb3e86b428d08
Cr-Commit-Position: refs/heads/master@{#426932}
==========

[commit-bot: I haz the power, 2016-10-22 00:15:14]

Patchset 3 (id:??) landed as
https://crrev.com/72a715afdc50e013d0c96a2042ecb3e86b428d08
Cr-Commit-Position: refs/heads/master@{#426932}