Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2433773008: Suppress a declarated-declaration warning for GetProcessInformation. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress a declarated-declaration warning for GetProcessInformation. There's no replacement method that does what we need. See bug for more details. BUG=650854 Committed: https://crrev.com/98b75a2586d9ad1b051708df2572fcdbc0dcd7da Cr-Commit-Position: refs/heads/master@{#426726}

Patch Set 1 #

Patch Set 2 : remove whitespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M base/mac/mac_util.mm View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
erikchen
mark: Please review.
4 years, 2 months ago (2016-10-21 01:29:04 UTC) #3
Mark Mentovai
LGTM
4 years, 2 months ago (2016-10-21 03:25:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433773008/20001
4 years, 2 months ago (2016-10-21 04:04:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 04:15:21 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:27:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98b75a2586d9ad1b051708df2572fcdbc0dcd7da
Cr-Commit-Position: refs/heads/master@{#426726}

Powered by Google App Engine
This is Rietveld 408576698