Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2433733002: Revert "Reusing Ok/Cancel buttons for intent picker" (Closed)

Created:
4 years, 2 months ago by huangs
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Reusing Ok/Cancel buttons for intent picker" This reverts commit a1fd64d48d76266f9c6db6378346cdec2f416c27. Reason: This seems to cause Linux ASan test failures in: IntentPickerBubbleViewTest.InkDropStateTransition IntentPickerBubbleViewTest.PressButtonTwice NOTRY=true TBR=djacobo,sky BUG=657240 Committed: https://crrev.com/5a7d8aa3bbe8d6526c49b406b20e367f5d7f8312 Cr-Commit-Position: refs/heads/master@{#426141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -323 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_external_protocol_dialog.cc View 2 chunks +5 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_navigation_throttle.h View 2 chunks +6 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_navigation_throttle.cc View 5 chunks +8 lines, -24 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 chunk +5 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/intent_picker_bubble_view.h View 4 chunks +29 lines, -34 lines 0 comments Download
M chrome/browser/ui/views/intent_picker_bubble_view.cc View 6 chunks +165 lines, -147 lines 0 comments Download
M chrome/browser/ui/views/intent_picker_bubble_view_unittest.cc View 7 chunks +13 lines, -55 lines 0 comments Download
M ui/views/controls/scroll_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433733002/1
4 years, 2 months ago (2016-10-19 03:57:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 10:01:39 UTC) #5
huangs
For reference, the link to reverted CL is http://crrev.com/2229943003/. After the reversion the ASan bug ...
4 years, 2 months ago (2016-10-19 14:24:59 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:06:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a7d8aa3bbe8d6526c49b406b20e367f5d7f8312
Cr-Commit-Position: refs/heads/master@{#426141}

Powered by Google App Engine
This is Rietveld 408576698