Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2433413002: Remove last-minute row height stretching for pagination. (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
rhogan, dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove last-minute row height stretching for pagination. This code no longer has any effect, since we now fragment and set the correct row heights way BEFORE cell alignment and flexing. It was also buggy, in that it didn't recalculate intrinsic padding after resizing the row. BUG=534751 Committed: https://crrev.com/fdff5a918e533da1a7fb723d2e758553d491349e Cr-Commit-Position: refs/heads/master@{#426512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 3 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 2 months ago (2016-10-20 13:24:22 UTC) #4
eae
Yay, LGTM!
4 years, 2 months ago (2016-10-20 16:54:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433413002/1
4 years, 2 months ago (2016-10-20 16:55:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 17:14:41 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:19:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fdff5a918e533da1a7fb723d2e758553d491349e
Cr-Commit-Position: refs/heads/master@{#426512}

Powered by Google App Engine
This is Rietveld 408576698