Pay attention to tall rowspanned cells in the first layout pass.

Pay attention to tall rowspanned cells in the first layout pass.

If a rowspanned cell gets fragmented, and this cell needs to stretch the table
rows in order to fit, only stretch the last row (i.e. the one we're currently
laying out). That's the only thing we can do if we don't want mess up
fragmentation (pagination struts) of earlier content.

Furthermore, to leave those rows completely alone, don't let a subsequent
rowspanned cell that shares at least one row with the previous rowspanned cell
stretch those rows, either, as that would lead to unfair height distribution
anyway (since the last row has already got all the extra space).
table-overlapping-rowspan.html tests this.

BUG=534751
Committed: https://crrev.com/8913722091969012d43990dacf8a7c0e403425d8
Cr-Commit-Position: refs/heads/master@{#426590}

[mstensho (USE GERRIT), 2016-10-20 12:13:00]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 12:13:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 13:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 13:21:44]

Dry run: This issue passed the CQ dry run.

[mstensho (USE GERRIT), 2016-10-20 13:22:58]

mstensho@opera.com changed reviewers:
+ dgrogan@chromium.org, eae@chromium.org

[eae, 2016-10-20 16:53:58]

LGTM w/nit

https://codereview.chromium.org/2433403002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTableSection.cpp (right):

https://codereview.chromium.org/2433403002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:2021: rowLogicalTop
- firstRowForCell->logicalTop().toInt();
Above you round the logicalTop and here you floor it. Given that all are ints it
probably doesn't matter much but it seems wrong to me.

[mstensho (USE GERRIT), 2016-10-20 19:05:56]

https://codereview.chromium.org/2433403002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutTableSection.cpp (right):

https://codereview.chromium.org/2433403002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutTableSection.cpp:2021: rowLogicalTop
- firstRowForCell->logicalTop().toInt();
On 2016/10/20 16:53:58, eae wrote:
> Above you round the logicalTop and here you floor it. Given that all are ints
it
> probably doesn't matter much but it seems wrong to me.

Better use toInt() everywhere, unless there are good reasons not to.

Done.

[mstensho (USE GERRIT), 2016-10-20 19:32:22]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-10-20 19:32:23]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2433403002/#ps40001
(title: "rebase master")

[commit-bot: I haz the power, 2016-10-20 19:33:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 20:56:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:22:18]

Description was changed from

==========
Pay attention to tall rowspanned cells in the first layout pass.

If a rowspanned cell gets fragmented, and this cell needs to stretch the table
rows in order to fit, only stretch the last row (i.e. the one we're currently
laying out). That's the only thing we can do if we don't want mess up
fragmentation (pagination struts) of earlier content.

Furthermore, to leave those rows completely alone, don't let a subsequent
rowspanned cell that shares at least one row with the previous rowspanned cell
stretch those rows, either, as that would lead to unfair height distribution
anyway (since the last row has already got all the extra space).
table-overlapping-rowspan.html tests this.

BUG=534751
==========

to

==========
Pay attention to tall rowspanned cells in the first layout pass.

If a rowspanned cell gets fragmented, and this cell needs to stretch the table
rows in order to fit, only stretch the last row (i.e. the one we're currently
laying out). That's the only thing we can do if we don't want mess up
fragmentation (pagination struts) of earlier content.

Furthermore, to leave those rows completely alone, don't let a subsequent
rowspanned cell that shares at least one row with the previous rowspanned cell
stretch those rows, either, as that would lead to unfair height distribution
anyway (since the last row has already got all the extra space).
table-overlapping-rowspan.html tests this.

BUG=534751

Committed: https://crrev.com/8913722091969012d43990dacf8a7c0e403425d8
Cr-Commit-Position: refs/heads/master@{#426590}
==========

[commit-bot: I haz the power, 2016-10-21 13:22:19]

Patchset 3 (id:??) landed as
https://crrev.com/8913722091969012d43990dacf8a7c0e403425d8
Cr-Commit-Position: refs/heads/master@{#426590}