Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2433373004: Initialize SecurityInfo::displayed_private_user_data_input_on_http. (Closed)

Created:
4 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
estark
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize SecurityInfo::displayed_private_user_data_input_on_http. This field must be initialized in the SecurityInfo constructor or else MSan gets mad and behavior becomes undefined. BUG=647561 Committed: https://crrev.com/7b819cf77ecd601c18c126a264b6f71dfd0974db Cr-Commit-Position: refs/heads/master@{#426625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/security_state/security_state_model.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Reilly Grant (use Gerrit)
Please take a look. The MSAN bots are red.
4 years, 2 months ago (2016-10-20 21:16:09 UTC) #2
estark
darnit! Thanks for the fix, lgtm
4 years, 2 months ago (2016-10-20 21:16:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433373004/1
4 years, 2 months ago (2016-10-20 21:18:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 22:46:28 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:23:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b819cf77ecd601c18c126a264b6f71dfd0974db
Cr-Commit-Position: refs/heads/master@{#426625}

Powered by Google App Engine
This is Rietveld 408576698