Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: BUILD.gn

Issue 2433343002: Only build libsrtp tests if a build flag is set (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index cd6a1a4113ab5d5d70953323fa258eb431a25ed6..df1e9b2f96b61fd9cf0c11fc4c8add33a5e690a1 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -4,6 +4,12 @@
import("//testing/test.gni")
+declare_args() {
+ # Tests may not be appropriate for some build environments, e.g. Windows.
+ # Rather than enumerate valid options, we just let clients ask for them.
+ build_libsrtp_tests = false
+}
+
config("libsrtp_config") {
defines = [
# Package identity
@@ -114,14 +120,7 @@ static_library("libsrtp") {
]
}
-if (is_win) {
- # Don't build tests on Windows. Upstream doesn't, so we can't assume the
- # tests will compile or run.
-
- group("srtp_tests") {
mattdr-at-chromium 2016/10/20 10:45:10 I decided there wasn't value in providing an empty
- testonly = true
- }
-} else {
+if (build_libsrtp_tests) {
config("srtp_test_config") {
include_dirs = [ "test" ]
configs = [ ":libsrtp_warnings" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698