Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2433323003: Fix TestingPlatformSupportWithMockScheduler::runForPeriodSeconds (Closed)

Created:
4 years, 2 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TestingPlatformSupportWithMockScheduler::runForPeriodSeconds When one calls runForPeriodSeconds(x) you naturally expect the testing clock to alwats advance by that many seconds. Unfortunately cc::OrderedSimpleTaskRunner is a strange beast and the actual time advances to the last delayed task before the deadline if any. This patch fixes that and makes the operation of timer fast forwarding explicit. It also fixes a bug in TimerTest.RepeatingTimerDoesNotDrift which was relying on strange behavior of cc::OrderedSimpleTaskRunner when setAutoAdvanceNowToPendingTasks is false. BUG=657517 Committed: https://crrev.com/98561e7b7897f88fbceed76c57cefa990c2cb90a Cr-Commit-Position: refs/heads/master@{#426545}

Patch Set 1 #

Patch Set 2 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M third_party/WebKit/Source/platform/TimerTest.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 2 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
alex clarke (OOO till 29th)
PTAL
4 years, 2 months ago (2016-10-20 14:39:39 UTC) #4
haraken
LGTM
4 years, 2 months ago (2016-10-20 14:44:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433323003/10006
4 years, 2 months ago (2016-10-20 15:30:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:10006)
4 years, 2 months ago (2016-10-20 18:51:05 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:20:44 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98561e7b7897f88fbceed76c57cefa990c2cb90a
Cr-Commit-Position: refs/heads/master@{#426545}

Powered by Google App Engine
This is Rietveld 408576698