[wasm] Only use the table maximum in allocation if it is non-zero.

[wasm] Only use the table maximum in allocation if it is non-zero.

R=ahaas@chromium.org
BUG=chromium:654231
Committed: https://crrev.com/ff46fcb9e4f113db5e1ad60973afe5685a29259c
Cr-Commit-Position: refs/heads/master@{#40458}

[titzer, 2016-10-20 09:03:48]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 09:03:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-10-20 09:09:42]

lgtm with nit

https://codereview.chromium.org/2433313002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2433313002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:1045: uint32_t size = table.max_size > 0 ?
table.max_size : table.size;
Could we just set the default value of table.max_size to kMaxTableSize instead
of setting it to 0?

[titzer, 2016-10-20 09:12:06]

On 2016/10/20 09:09:42, ahaas wrote:
> lgtm with nit
> 
> https://codereview.chromium.org/2433313002/diff/1/src/wasm/wasm-module.cc
> File src/wasm/wasm-module.cc (right):
> 
>
https://codereview.chromium.org/2433313002/diff/1/src/wasm/wasm-module.cc#new...
> src/wasm/wasm-module.cc:1045: uint32_t size = table.max_size > 0 ?
> table.max_size : table.size;
> Could we just set the default value of table.max_size to kMaxTableSize instead
> of setting it to 0?

That's not so great, since the current code allocates the maximum size if it
exists. That'd mean we always allocate the maximum size.

[titzer, 2016-10-20 09:13:04]

The CQ bit was unchecked by titzer@chromium.org

[titzer, 2016-10-20 09:13:09]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-10-20 09:13:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 09:33:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:07:32]

Description was changed from

==========
[wasm] Only use the table maximum in allocation if it is non-zero.

R=ahaas@chromium.org
BUG=chromium:654231
==========

to

==========
[wasm] Only use the table maximum in allocation if it is non-zero.

R=ahaas@chromium.org
BUG=chromium:654231

Committed: https://crrev.com/ff46fcb9e4f113db5e1ad60973afe5685a29259c
Cr-Commit-Position: refs/heads/master@{#40458}
==========

[commit-bot: I haz the power, 2016-11-17 22:07:33]

Patchset 1 (id:??) landed as
https://crrev.com/ff46fcb9e4f113db5e1ad60973afe5685a29259c
Cr-Commit-Position: refs/heads/master@{#40458}