Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2433293002: Roll WebGL 4e6c509..b1aed3a (Closed)

Created:
4 years, 2 months ago by yunchao
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL 4e6c509..b1aed3a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c509..b1aed3a BUG=644740 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/8b35131cc20dddd3b7d1260fea7f221b8c1c6035 Cr-Commit-Position: refs/heads/master@{#426683}

Patch Set 1 #

Patch Set 2 : suppress webgl expectations #

Total comments: 1

Patch Set 3 : suppress more webgl expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (26 generated)
yunchao
Roll in the patch at https://github.com/KhronosGroup/WebGL/pull/2086 to run on all bots, in order to test ...
4 years, 2 months ago (2016-10-20 07:53:09 UTC) #6
yunchao
Suppress the webgl expectation https://codereview.chromium.org/2433293002/diff/40001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2433293002/diff/40001/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py#newcode58 content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:58: self.Fail('conformance/glsl/bugs/samplers-in-ternary-operator.html', This test can pass ...
4 years, 2 months ago (2016-10-20 16:07:37 UTC) #13
yunchao
@geofflang, I think blitframebuffer-filter-outofbounds.html can pass on Linux AMD after this roll-in. Could you have ...
4 years, 2 months ago (2016-10-20 16:18:59 UTC) #18
Geoff Lang
On 2016/10/20 16:18:59, yunchao wrote: > @geofflang, I think blitframebuffer-filter-outofbounds.html can pass on Linux > ...
4 years, 2 months ago (2016-10-20 16:27:08 UTC) #21
Zhenyao Mo
lgtm
4 years, 2 months ago (2016-10-20 16:33:52 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433293002/60001
4 years, 2 months ago (2016-10-21 01:26:49 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-21 01:39:36 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:25:54 UTC) #34
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b35131cc20dddd3b7d1260fea7f221b8c1c6035
Cr-Commit-Position: refs/heads/master@{#426683}

Powered by Google App Engine
This is Rietveld 408576698