|
|
Chromium Code Reviews
DescriptionRoll WebGL 4e6c509..b1aed3a
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c509..b1aed3a
BUG=644740
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/8b35131cc20dddd3b7d1260fea7f221b8c1c6035
Cr-Commit-Position: refs/heads/master@{#426683}
Patch Set 1 #Patch Set 2 : suppress webgl expectations #
Total comments: 1
Patch Set 3 : suppress more webgl expectation #
Messages
Total messages: 34 (26 generated)
Description was changed from ========== Roll WebGL 4e6c509..b1aed3a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c50... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Merge branch 'master' of https://chromium.googlesource.com/chromium/src fix ========== to ========== Roll WebGL 4e6c509..b1aed3a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c50... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yunchao.he@intel.com changed reviewers: + kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org
Roll in the patch at https://github.com/KhronosGroup/WebGL/pull/2086 to run on all bots, in order to test blitting pixels exactly on effective sampling bounds. PTAL. Thanks a lot!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
Suppress the webgl expectation https://codereview.chromium.org/2433293002/diff/40001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2433293002/diff/40001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:58: self.Fail('conformance/glsl/bugs/samplers-in-ternary-operator.html', This test can pass on a few platforms (a few OSes + GPU vendors), but it fails on many platforms. I would like not to bother to list all platforms one by one.
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll WebGL 4e6c509..b1aed3a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c50... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 4e6c509..b1aed3a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c50... BUG=644740 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
yunchao.he@intel.com changed reviewers: + geofflang@chromium.org
@geofflang, I think blitframebuffer-filter-outofbounds.html can pass on Linux AMD after this roll-in. Could you have a double-check? Thanks in advance. You marked it fail on Linux/AMD at this CL: https://codereview.chromium.org/2436653004/.
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/20 16:18:59, yunchao wrote: > @geofflang, I think blitframebuffer-filter-outofbounds.html can pass on Linux > AMD after this roll-in. Could you have a double-check? Thanks in advance. You > marked it fail on Linux/AMD at this CL: > https://codereview.chromium.org/2436653004/. Ok, we'll wait and see what happens in this roll. The bot it was failing on is here: https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A.... It looks like the bot is also failing the WebglConformance_deqp_functional_gles3_framebufferblit_default_framebuffer_00 test now after this CL: https://chromiumcodereview.appspot.com/2409523002
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yunchao.he@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 4e6c509..b1aed3a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c50... BUG=644740 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 4e6c509..b1aed3a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c50... BUG=644740 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 4e6c509..b1aed3a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c50... BUG=644740 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 4e6c509..b1aed3a https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/4e6c50... BUG=644740 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/8b35131cc20dddd3b7d1260fea7f221b8c1c6035 Cr-Commit-Position: refs/heads/master@{#426683} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8b35131cc20dddd3b7d1260fea7f221b8c1c6035 Cr-Commit-Position: refs/heads/master@{#426683} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
