Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2433283003: [Offline Page] Fix test failure on svelte devices. (Closed)

Created:
4 years, 2 months ago by romax
Modified:
4 years, 2 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Page] Fix test failure on svelte devices. The failure was because we weren't trying to run tests on low-end devices and we weren't trying to do immediate scheduling on svelte devices. Adding a call to the callback resolved the issue. BUG=657775 Committed: https://crrev.com/875cef2100560bcb9308e72742f7b5a00c2c66ab Cr-Commit-Position: refs/heads/master@{#426676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M components/offline_pages/background/request_coordinator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M components/offline_pages/background/request_coordinator_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
romax
PTAL, thanks.
4 years, 2 months ago (2016-10-20 22:50:52 UTC) #2
Pete Williamson
lgtm
4 years, 2 months ago (2016-10-20 22:53:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2433283003/1
4 years, 2 months ago (2016-10-20 23:10:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 01:26:55 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:25:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/875cef2100560bcb9308e72742f7b5a00c2c66ab
Cr-Commit-Position: refs/heads/master@{#426676}

Powered by Google App Engine
This is Rietveld 408576698