Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: include/v8.h

Issue 2433273002: [wasm] Avoid double-serializing the wire bytes (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/runtime/runtime-test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 655da2ab2b97a53a9d2c077a68083b62d69ef931..a988a185f746b34b0b6ab2edc63dba10efaca008 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3906,10 +3906,6 @@ class V8_EXPORT WasmCompiledModule : public Object {
// uncompiled bytes.
SerializedModule Serialize();
- // TODO(mtrofin): Back-compat. Move to private once change lands in Chrome.
- // The resulting wasm setup won't have its uncompiled bytes available.
- static MaybeLocal<WasmCompiledModule> Deserialize(
- Isolate* isolate, const SerializedModule& serialized_module);
// If possible, deserialize the module, otherwise compile it from the provided
// uncompiled bytes.
static MaybeLocal<WasmCompiledModule> DeserializeOrCompile(
@@ -3919,7 +3915,8 @@ class V8_EXPORT WasmCompiledModule : public Object {
private:
static MaybeLocal<WasmCompiledModule> Deserialize(
- Isolate* isolate, const CallerOwnedBuffer& serialized_module);
+ Isolate* isolate, const CallerOwnedBuffer& serialized_module,
+ const CallerOwnedBuffer& wire_bytes);
static MaybeLocal<WasmCompiledModule> Compile(Isolate* isolate,
const uint8_t* start,
size_t length);
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/runtime/runtime-test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698